Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: remove github.com/google/go-cmp from main package #90

Closed
wants to merge 1 commit into from
Closed

RFC: remove github.com/google/go-cmp from main package #90

wants to merge 1 commit into from

Conversation

pohly
Copy link

@pohly pohly commented Mar 28, 2023 •
edited

When moving the unit test into a sub-directory with its own go.mod file it becomes possible to remove the github.com/google/go-cmp dependency from the module that gets imported by downstream consumers.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pohly
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 28, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2023
@pohly pohly force-pushed the minimize-deps branch 2 times, most recently from a076e36 to efaf410 Compare March 28, 2023 07:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2023
@pohly
remove github.com/google/go-cmp from main package
ed4377f 
When moving the unit test into a sub-directory with its own go.mod file it
becomes possible to remove the github.com/google/go-cmp dependency from the
module that gets imported by downstream consumers.
@pohly
Copy link
Author

pohly commented May 16, 2023

/close

Due to lack of interest (from reviewers and myself 🥲 ).

@k8s-ci-robot
Copy link

@pohly: Closed this PR.

In response to this:

/close

Due to lack of interest (from reviewers and myself 🥲 ).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pohly @k8s-ci-robot