Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added github-actions CI #50

Merged
merged 1 commit into from Jan 26, 2021
Merged

added github-actions CI #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/go.yml
View file
Open in desktop
@@ -0,0 +1,31 @@
name: Go

on:
push:
branches: [ master ]
pull_request:
branches: [ master ]
jobs:
build:
strategy:
matrix:
go-versions: [1.12.x, 1.13.x, 1.14.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add newer go 1.15.x in a follow up PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will get on it right away

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a different note ;

  • Travis CI was explicit about distro and release (ubuntu-xenial) and the github-actions is now using "ubuntu-latest" which is translating to xenial for now. But the GH-Actions is also showing this message ;
Ubuntu-latest workflows will use Ubuntu-20.04 soon. For more details, see https://github.com/actions/virtual-environments/issues/1816

Does this require any attention or is "ubuntu-latest" ok when GH starts using focal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please advise if "only" add 1.15.x or remove 1.12.x as well. thnx

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: ${{ matrix.go-versions }}
- name: Install
run: GO111MODULE=off go get golang.org/x/lint/golint
- name: Run gofmt
run: diff -u <(echo -n) <(gofmt -d *.go)
- name: Run golint
run: diff -u <(echo -n) <(golint $(go list -e ./...) | grep -v YAMLToJSON)
- name: Run go vet
run: GO111MODULE=on go vet .
- name: Run go test
run: GO111MODULE=on go test -v -race ./...
- name: Check diff
run: git diff --exit-code