-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to define (overwrite) of securityContext or pod security context #1438
base: main
Are you sure you want to change the base?
Add support to define (overwrite) of securityContext or pod security context #1438
Conversation
Welcome @cbugneac-nex! |
Hi @cbugneac-nex. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature |
da64e26
to
18de24f
Compare
18de24f
to
8a9a773
Compare
8a9a773
to
64e0757
Compare
afe2a1a
to
896e370
Compare
bd68c24
to
6e1b193
Compare
6e1b193
to
813d013
Compare
Hi @aramase please could you review it once again ? |
manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml
Outdated
Show resolved
Hide resolved
{{- with .Values.podSecurityContext }} | ||
{{- toYaml . | nindent 8 }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{- with .Values.podSecurityContext }} | |
{{- toYaml . | nindent 8 }} | |
{{- end }} | |
{{- toYaml .Values.linux.podSecurityContext | nindent 8 }} |
manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml
Outdated
Show resolved
Hide resolved
@@ -36,6 +36,12 @@ spec: | |||
{{- end }} | |||
affinity: | |||
{{ toYaml .Values.linux.affinity | indent 8 }} | |||
securityContext: | |||
{{- /* This is required for the driver to function correctly. */}} | |||
privileged: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is privileged: true
being moved from container to the pod security context?
imagePullPolicy: {{ .Values.linux.livenessProbe.pullPolicy }} | ||
{{- with .Values.linux.livenessProbe.securityContext }} | ||
securityContext: | ||
{{- toYaml . | nindent 12 }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above
…rets-store-csi-driver.yaml Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
…rets-store-csi-driver.yaml Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cbugneac-nex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Add support to define (overwrite) SecurityContext for containers & pod security context.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1437
Special notes for your reviewer:
Link helm chart:
$ helm lint ./ ==> Linting ./ 1 chart(s) linted, 0 chart(s) failed
TODOs: