Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to define (overwrite) of securityContext or pod security context #1438

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cbugneac-nex
Copy link

@cbugneac-nex cbugneac-nex commented Feb 12, 2024

What this PR does / why we need it:
Add support to define (overwrite) SecurityContext for containers & pod security context.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1437

Special notes for your reviewer:

Link helm chart:

$ helm lint ./
==> Linting ./

1 chart(s) linted, 0 chart(s) failed

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @cbugneac-nex!

It looks like this is your first PR to kubernetes-sigs/secrets-store-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @cbugneac-nex. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2024
@cbugneac-nex
Copy link
Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 12, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2024
@cbugneac-nex cbugneac-nex force-pushed the support_security_context_#1437 branch 3 times, most recently from afe2a1a to 896e370 Compare February 12, 2024 19:10
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2024
@cbugneac-nex cbugneac-nex force-pushed the support_security_context_#1437 branch 4 times, most recently from bd68c24 to 6e1b193 Compare February 12, 2024 19:21
@cbugneac-nex cbugneac-nex changed the title Support overwrite of securityContext Add support to define (overwrite) of securityContext or pod security context Feb 12, 2024
@cbugneac-nex
Copy link
Author

Hi @aramase @nilekhc please could you review this PR ?

@cbugneac-nex
Copy link
Author

Hi @aramase @nilekhc @ritazh @tam7t please could you review this PR when you have time ?

@cbugneac-nex
Copy link
Author

Hi @aramase please could you review it once again ?

@cbugneac-nex
Copy link
Author

Hi @aramase @nilekhc @ritazh @tam7t please could you review this PR when you have time ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024
Copy link

linux-foundation-easycla bot commented Mar 12, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2024
Comment on lines 42 to 44
{{- with .Values.podSecurityContext }}
{{- toYaml . | nindent 8 }}
{{- end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{- with .Values.podSecurityContext }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- toYaml .Values.linux.podSecurityContext | nindent 8 }}

@@ -36,6 +36,12 @@ spec:
{{- end }}
affinity:
{{ toYaml .Values.linux.affinity | indent 8 }}
securityContext:
{{- /* This is required for the driver to function correctly. */}}
privileged: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is privileged: true being moved from container to the pod security context?

Comment on lines +165 to +169
imagePullPolicy: {{ .Values.linux.livenessProbe.pullPolicy }}
{{- with .Values.linux.livenessProbe.securityContext }}
securityContext:
{{- toYaml . | nindent 12 }}
{{- end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

…rets-store-csi-driver.yaml

Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase self-assigned this Mar 26, 2024
…rets-store-csi-driver.yaml

Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cbugneac-nex
Once this PR has been reviewed and has the lgtm label, please ask for approval from aramase. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add support to define (overwrite) SecurityContext
4 participants