-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add labels to metrics #1433
base: main
Are you sure you want to change the base?
chore: add labels to metrics #1433
Conversation
Hi @Suraiya-Hameed. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Suraiya-Hameed The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@aramase is there anything I should do about the |
Nothing you need to do. It seems to be a flake with cluster creation. |
/retest-required |
@aramase gentle nudge to review this PR. |
/assign nilekhc |
05df2a7
to
7eb8f38
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
==========================================
+ Coverage 36.54% 36.82% +0.28%
==========================================
Files 63 63
Lines 4532 4567 +35
==========================================
+ Hits 1656 1682 +26
- Misses 2732 2741 +9
Partials 144 144 ☔ View full report in Codecov by Sentry. |
38a5332
to
4fb19fa
Compare
08dd07f
to
525f176
Compare
What type of PR is this?
/kind feature
/kind documentation
What this PR does / why we need it:
pod_name
,pod_namespace
andsecret_provider_class
to the existing metrics.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1344
Special notes for your reviewer:
TODOs: