Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add labels to metrics #1433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Suraiya-Hameed
Copy link
Contributor

@Suraiya-Hameed Suraiya-Hameed commented Jan 30, 2024

What type of PR is this?
/kind feature
/kind documentation

What this PR does / why we need it:

  • Adds additional labels pod_name, pod_namespace and secret_provider_class to the existing metrics.
  • Fixes documentation about current metrics

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1344

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Suraiya-Hameed. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Suraiya-Hameed
Once this PR has been reviewed and has the lgtm label, please assign aramase for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2024
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2024
@Suraiya-Hameed
Copy link
Contributor Author

@aramase is there anything I should do about the pull-secrets-store-csi-driver-e2e-windows tests failing, looks like intermittent failure from the history!

@aramase
Copy link
Member

aramase commented Feb 5, 2024

@aramase is there anything I should do about the pull-secrets-store-csi-driver-e2e-windows tests failing, looks like intermittent failure from the history!

Nothing you need to do. It seems to be a flake with cluster creation.

@aramase
Copy link
Member

aramase commented Feb 5, 2024

/retest-required

@Suraiya-Hameed
Copy link
Contributor Author

@aramase gentle nudge to review this PR.

@aramase
Copy link
Member

aramase commented Feb 22, 2024

/assign nilekhc

docs/book/src/topics/metrics.md Outdated Show resolved Hide resolved
pkg/secrets-store/nodeserver_test.go Show resolved Hide resolved
@Suraiya-Hameed Suraiya-Hameed force-pushed the csi-metric-label branch 2 times, most recently from 05df2a7 to 7eb8f38 Compare February 22, 2024 20:11
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 74.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 36.82%. Comparing base (608fae1) to head (7eb8f38).

Files Patch % Lines
pkg/secrets-store/stats_reporter.go 0.00% 12 Missing ⚠️
pkg/secrets-store/mocks/stats_reporter_mock.go 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
+ Coverage   36.54%   36.82%   +0.28%     
==========================================
  Files          63       63              
  Lines        4532     4567      +35     
==========================================
+ Hits         1656     1682      +26     
- Misses       2732     2741       +9     
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Suraiya-Hameed Suraiya-Hameed force-pushed the csi-metric-label branch 2 times, most recently from 38a5332 to 4fb19fa Compare March 19, 2024 17:49
controllers/secretproviderclasspodstatus_controller.go Outdated Show resolved Hide resolved
pkg/rotation/reconciler.go Show resolved Hide resolved
pkg/secrets-store/nodeserver_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Metrics Labels to Reflect Affected Resources
5 participants