New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added first draft of replacement between delimiter #5617
base: master
Are you sure you want to change the base?
feat: added first draft of replacement between delimiter #5617
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Yingrjimsch The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Yingrjimsch! |
Hi @Yingrjimsch. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
758a50c
to
4210131
Compare
Edit: I decided to add a fulltext replacement as well because it was very similar to the start and enddelimiter. Should not be too much to review and is pretty straightforward. |
/assign @ncapps |
/assign @varshaprasad96 |
hi, any ETA on the merge of this PR? |
I tried via Slack and Assigning to find someone but until now I got sadly no reaction... |
Hi @Yingrjimsch thanks for your contribution, I have been checked how to migrate from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Implementation of Issue 5616
#5616