Add an option in kustomize lib to suppress the deprecation warnings #5466

davidbaena · 2023-11-28T21:13:34Z

The goal of this PR is to add and Logger option to suppress warnings if user integrates kustomize in his project.
But the kustomize binary still printing warnings by default.

Implementation
I injected a slog.Logger in KustTarget this way the lib user might pass a custom logger.

In order to configure this logger, I extended de Options to add a new field called LogLevel which is filled by default as Info (just to be compatible with the current binary version)

Fixes: #5452

./go/bin/kustomize build kustomization-foo
{"time":"2023-11-29T21:26:25.85695+01:00","level":"WARN","msg":"# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically."}
...

k8s-ci-robot · 2023-11-28T21:13:37Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-11-28T21:13:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidbaena
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-11-28T21:13:43Z

Welcome @davidbaena!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-11-28T21:13:44Z

Hi @davidbaena. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

davidbaena · 2023-11-28T21:15:24Z

api/internal/target/kusttarget.go

@@ -67,7 +71,7 @@ func (kt *KustTarget) Load() error {
 	// show warning message when using deprecated fields.
 	if warningMessages := k.CheckDeprecatedFields(); warningMessages != nil {
 		for _, msg := range *warningMessages {
-			fmt.Fprintf(os.Stderr, "%v\n", msg)


This was the hardcoded warning

davidbaena · 2023-11-29T20:43:00Z

Hello @natasha41575 could you help me with the review process?

natasha41575 · 2023-11-30T16:42:40Z

/ok-to-test

davidbaena · 2023-11-30T20:50:54Z

/retest

davidbaena · 2023-11-30T21:53:31Z

/retest-required

davidbaena · 2023-11-30T22:07:44Z

/test all

davidbaena · 2023-12-02T16:03:38Z

/test MacOS

k8s-ci-robot · 2023-12-02T16:03:54Z

@davidbaena: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test kustomize-presubmit-master

Use /test all to run all jobs.

In response to this:

/test MacOS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

davidbaena · 2023-12-11T09:09:49Z

Hello @yuwenma, @annasong20, do you mind to review this PR 🙏
If you need some extra description do not hesitate to ask me 💪

k8s-triage-robot · 2024-03-10T10:07:57Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot · 2024-03-27T18:34:36Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2024-04-26T19:27:45Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

davidbaena changed the title ~~Add an option in kustomize lib to suppress the deprecation warnings.~~ Add an option in kustomize lib to suppress the deprecation warnings Nov 28, 2023

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2023

k8s-ci-robot requested review from annasong20 and yuwenma November 28, 2023 21:13

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 28, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2023

davidbaena commented Nov 28, 2023

View reviewed changes

davidbaena mentioned this pull request Nov 29, 2023

Add an option in kustomize lib to suppress the deprecation warnings. #5452

Open

2 tasks

davidbaena added 3 commits November 29, 2023 21:23

Add slog LevelFlag to Kustomizer options

be62694

Set tests logLevel to Error

8ef69e3

Change slog NewTextHandler to NewJSONHandler

ba78211

davidbaena force-pushed the issue-5452/knob-suppress-warnings branch from d7d15eb to ba78211 Compare November 29, 2023 20:25

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2023

natasha41575 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 30, 2023

Fix lint

ff4743f

Print warning errors to os.Stderr

3ef9a0a

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2024

VaishnaviHire mentioned this pull request Mar 29, 2024

feat(logger): for both controller level and component level opendatahub-io/opendatahub-operator#837

Merged

3 tasks

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an option in kustomize lib to suppress the deprecation warnings #5466

Add an option in kustomize lib to suppress the deprecation warnings #5466

davidbaena commented Nov 28, 2023 •

edited

k8s-ci-robot commented Nov 28, 2023

k8s-ci-robot commented Nov 28, 2023

k8s-ci-robot commented Nov 28, 2023

k8s-ci-robot commented Nov 28, 2023

davidbaena Nov 28, 2023 •

edited

davidbaena commented Nov 29, 2023

natasha41575 commented Nov 30, 2023

davidbaena commented Nov 30, 2023

davidbaena commented Nov 30, 2023

davidbaena commented Nov 30, 2023

davidbaena commented Dec 2, 2023

k8s-ci-robot commented Dec 2, 2023

davidbaena commented Dec 11, 2023

k8s-triage-robot commented Mar 10, 2024

k8s-ci-robot commented Mar 27, 2024

k8s-triage-robot commented Apr 26, 2024

Add an option in kustomize lib to suppress the deprecation warnings #5466

Are you sure you want to change the base?

Add an option in kustomize lib to suppress the deprecation warnings #5466

Conversation

davidbaena commented Nov 28, 2023 • edited

k8s-ci-robot commented Nov 28, 2023

k8s-ci-robot commented Nov 28, 2023

k8s-ci-robot commented Nov 28, 2023

k8s-ci-robot commented Nov 28, 2023

davidbaena Nov 28, 2023 • edited

Choose a reason for hiding this comment

davidbaena commented Nov 29, 2023

natasha41575 commented Nov 30, 2023

davidbaena commented Nov 30, 2023

davidbaena commented Nov 30, 2023

davidbaena commented Nov 30, 2023

davidbaena commented Dec 2, 2023

k8s-ci-robot commented Dec 2, 2023

davidbaena commented Dec 11, 2023

k8s-triage-robot commented Mar 10, 2024

k8s-ci-robot commented Mar 27, 2024

k8s-triage-robot commented Apr 26, 2024

davidbaena commented Nov 28, 2023 •

edited

davidbaena Nov 28, 2023 •

edited