Revert remote url-related changes in #4652 #4774
Conversation
Revert due to code freeze issue kubernetes-sigs#4756
k8s-ci-robot
added
cncf-cla: yes
|
Hi @annasong20. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: annasong20 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| // If host is a http(s) or ssh URL, grab the domain part. | ||
| for _, p := range Schemes() { | ||
| for _, p := range []string{ | ||
| "ssh://", "https://", "http://"} { |
There was a problem hiding this comment.
This revert should include removing Schemes (L23) because it was introduced for this change
There was a problem hiding this comment.
Schemes should be treated the same as HasRemoteFileScheme in fileloader.go. They are additions that don't affect the code path loading remotes.
There was a problem hiding this comment.
Are you using it anywhere else or planning to use it in a future PR?
I want to make sure we are not keeping around code that isn’t or won’t be used.
Revert url changes and related changes in url-processing code paths in #4652 due to code freeze issue #4756.