Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip more flaky tests #4638

Merged
merged 1 commit into from May 12, 2022
Merged

Skip more flaky tests #4638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions api/krusty/remoteload_test.go
View file
Open in desktop
Expand Up @@ -196,6 +196,8 @@ func TestRemoteResourcePort(t *testing.T) {
func TestRemoteResourceRepo(t *testing.T) {
tests := map[string]remoteResourceCase{
"https, no ref": {
// TODO: fix flaky test that sporadically throws errors on server
skip: true,
kustomization: `
resources:
- https://github.com/annasong20/kustomize-test.git`,
Expand Down Expand Up @@ -227,28 +229,29 @@ func TestRemoteResourceParameters(t *testing.T) {
sshNoParams := "git@github.com:kubernetes-sigs/kustomize//examples/multibases/dev"

// TODO: cases with expected errors are query parameter combinations that aren't supported yet; implement in future
// TODO: fix flaky tests (non-ssh tests that we skip) that sporadically fail on server
tests := map[string]remoteResourceCase{
// TODO: fix flaky test that passes locally, but sometimes fails on server
"https no params": {
skip: true,
kustomization: fmt.Sprintf(resourcesField, httpsNoParam),
error: true,
expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsNoParam),
},
// TODO: fix flaky test that passes locally, but sometimes fails on server
"https master": {
skip: true,
kustomization: fmt.Sprintf(resourcesField, httpsMasterBranch),
error: true,
expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsMasterBranch),
},
"https master and no submodules": {
skip: true,
kustomization: `
resources:
- https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev?ref=master&submodules=false`,
expected: multibaseDevExampleBuild,
},
"https all params": {
skip: true,
kustomization: `
resources:
- https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev?ref=v1.0.6&timeout=10&submodules=true`,
Expand Down Expand Up @@ -281,20 +284,24 @@ resources:
}

func TestRemoteResourceGoGetter(t *testing.T) {
// TODO: fix flaky tests (the ones that we skip) that fail sporadically on server
tests := map[string]remoteResourceCase{
"git detector with / subdirectory separator": {
skip: true,
kustomization: `
resources:
- github.com/kubernetes-sigs/kustomize/examples/multibases/dev/?ref=v1.0.6`,
expected: multibaseDevExampleBuild,
},
"git detector for repo": {
skip: true,
kustomization: `
resources:
- github.com/annasong20/kustomize-test`,
expected: multibaseDevExampleBuild,
},
"https with / subdirectory separator": {
skip: true,
kustomization: `
resources:
- https://github.com/kubernetes-sigs/kustomize/examples/multibases/dev/?ref=v1.0.6`,
Expand All @@ -307,6 +314,7 @@ resources:
expected: multibaseDevExampleBuild,
},
"git forced protocol with / subdirectory separator": {
skip: true,
kustomization: `
resources:
- git::https://github.com/kubernetes-sigs/kustomize/examples/multibases/dev/?ref=v1.0.6`,
Expand Down