Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing code leaked to production #4635

Merged
merged 3 commits into from May 19, 2022
Merged

Testing code leaked to production #4635

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b11cc3a
Fix comments
konrad945 May 12, 2022
ddf7681
Rename testing.go to testing_test.go
konrad945 May 12, 2022
ba7315c
Update testing_test.go
konrad945 May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions kyaml/kio/testing.go → kyaml/kio/testing_test.go
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@ type Setup struct {
Root string
}

// setupDirectories creates directories for reading test configuration from
// SetupDirectories creates directories for reading test configuration from
func SetupDirectories(t *testing.T, dirs ...string) Setup {
t.Helper()
d, err := ioutil.TempDir("", "kyaml-test")
Expand All @@ -32,7 +32,7 @@ func SetupDirectories(t *testing.T, dirs ...string) Setup {
return Setup{Root: d}
}

// writeFile writes a file under the test directory
// WriteFile writes a file under the test directory
func (s Setup) WriteFile(t *testing.T, path string, value []byte) {
t.Helper()
err := os.MkdirAll(filepath.Dir(filepath.Join(s.Root, path)), 0700)
Expand All @@ -41,7 +41,7 @@ func (s Setup) WriteFile(t *testing.T, path string, value []byte) {
require.NoError(t, err)
}

// clean deletes the test config
// Clean deletes the test config
func (s Setup) Clean() {
os.RemoveAll(s.Root)
}