Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error for enable_create_option_and_replacement_sequenceNode #4608

Conversation

koba1t
Copy link
Member

@koba1t koba1t commented Apr 25, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @koba1t. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: koba1t
To complete the pull request process, please assign natasha41575 after the PR has been reviewed.
You can assign the PR to them by writing /assign @natasha41575 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2022
@koba1t koba1t changed the title fix https://github.com/kubernetes-sigs/kustomize/pull/4577#discussion_r847718929 enable_create_option_and_replacement_sequenceNode fix error for enable_create_option_and_replacement_sequenceNode Apr 25, 2022
@koba1t
Copy link
Member Author

koba1t commented Apr 25, 2022

hi @natasha41575
I fix #4577 (review).
Sorry too late. Please check this PR.

@natasha41575
Copy link
Contributor

natasha41575 commented Jun 22, 2022

It looks like this is covered by my PR #4667. I really appreciate the effort but I think I can take this one, as there are some comments I've started to address in mine. I plan to update my PR this week, feel free to review it if you'd like!

If you're interested in helping with replacements more, here are a couple other issues that could use some help:

#4679
#4469

If you'd like to take those, just leave a comment on the issue like /assign and it should assign it to you.

@koba1t koba1t closed this Jul 15, 2022
@koba1t koba1t deleted the fix_error_when_create_enable_and_replacement_sequenceNode branch July 15, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants