feat: support edit set label for labels and not only commonLabels

[gaeljw]

Aims to solves #3866

Please review with care as I've never written Go before!

Also unit tests doesn't actually go through the command parsing so there might be issues on this part. I don't know how to test a whole command. If you do, please feel free to complete.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Gaël Jourdan-Weil (5cb0041)

[k8s-ci-robot]

Welcome @gaeljw!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @gaeljw. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[natasha41575]

/assign

[natasha41575]

/assign

[natasha41575]

/ok-to-test

[natasha41575]

/ok-to-test

[natasha41575]

A couple more things that this PR needs to go in:

1. The same change should be made to kustomize edit add label and kustomize edit remove label

2. I pulled your branch and ran kustomize edit set label foo:bar --fields=labels, which gave me:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
commonLabels:
  foo: bar
labels:
- {}
- pairs:
    foo: bar

This needs to be fixed before we can merge this PR. You can try this out yourself by going into the kustomize/kustomize directory and running go install . to build your branch.

[gaeljw]

/reopen

[k8s-ci-robot]

@gaeljw: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gaeljw
Once this PR has been reviewed and has the lgtm label, please ask for approval from natasha41575. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afirth]

anything I can do to help get either #4486 or this over the line?

[natasha41575]

/triage accepted

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gaeljw]

/reopen

[k8s-ci-robot]

@gaeljw: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afirth]

/remove-lifecycle rotten

[nhamlh]

I'd love to see this PR got merged soon. May I ask which is blocking this?

[nouney]

Any updates?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[stormqueen1990]

/remove-lifecycle stale
/cc

[stormqueen1990]

Hi there, @gaeljw!

Are you still interested in contributing this feature? If yes, could you please rebase this branch and resolve the existing conflicts?

[gaeljw]

I don't have much time to rebase my work and fix the conflicts currently. If anyone else wants to take over, I don't mind at all. Given that I know nothing about Go, this will probably more efficient anyway.

[stormqueen1990]

I don't have much time to rebase my work and fix the conflicts currently. If anyone else wants to take over, I don't mind at all. Given that I know nothing about Go, this will probably more efficient anyway.

I see. Appreciate the response 🙏🏼

[cunyat]

Hi there! I was looking arround for this feature and looked to rebase the PR, but i found that some similar feature was already introduced by #4486.

How can i help on this? I suppose thats better to keep already merged flags but i think it's better what this PR proposes (--include-selectors).
Also, few things that could be improved:

• Current implementation duplicates labels entries, this PR checks if already exists on add and fails if --force was not present.
• I think that would be good to also include --labels-without-template or --include-templates for allowing propagation of labels to templates without putting them in selectors.

[stormqueen1990]

Hi there! I was looking arround for this feature and looked to rebase the PR, but i found that some similar feature was already introduced by #4486.

How can i help on this? I suppose thats better to keep already merged flags but i think it's better what this PR proposes (--include-selectors). Also, few things that could be improved:

• Current implementation duplicates labels entries, this PR checks if already exists on add and fails if --force was not present.
• I think that would be good to also include --labels-without-template or --include-templates for allowing propagation of labels to templates without putting them in selectors.

Hi there, @cunyat!

Sorry for my late response! If you're interested in contributing the feature yourself, you can open a PR against this repository with your proposed changes, mentioning the referenced issue in your pull request description.