new openapi package using gnostic/openapiv2 #4474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Feb 14, 2022
natasha41575
added
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new package in the openapi directory that uses the "github.com/googleapis/gnostic/openapiv2" instead of "k8s.io/kube-openapi/pkg/validation/spec", which we have discovered can improve performance.
Rather than rewrite the entirety of the original library all at once, the idea here is to start a new library that will support the same features as our current library, but putting it in a separate internal while we develop incrementally with a lot of testing. When this some of the features are ready for consumption, we can start to replace our current library with this new one.
Related: #3670, kptdev/kpt#2651
/cc @mengqiy
FYI @droot @yuwenma. We can sync on this.