Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Fieldspec filter supports wildcard match #4457

Closed
wants to merge 1 commit into from

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Feb 7, 2022

more context in #4456

@KnVerey @natasha41575 Let me know how you feel about this approach. If it is okay, I'll add unittest and am happy to extend the wildcard feature to fieldspec based filters (like fieldspec, fsslice, etc) as well

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuwenma
To complete the pull request process, please assign natasha41575 after the PR has been reviewed.
You can assign the PR to them by writing /assign @natasha41575 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@yuwenma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kustomize-presubmit-master 971e558 link true /test kustomize-presubmit-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@natasha41575
Copy link
Contributor

Thanks! I left a comment on #4456

@yuwenma yuwenma closed this Feb 9, 2022
@yuwenma
Copy link
Contributor Author

yuwenma commented Feb 9, 2022

Per offline discussion, kustomize will not support fieldspec-level wildcard match from the perspective of avoiding users to do unstructured editing https://kubectl.docs.kubernetes.io/faq/kustomize/eschewedfeatures/#unstructured-edits

@KnVerey @natasha41575 Correct me if the comment is inaccurate and feel free to add rationales.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants