Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TrackableFilter interface #4410

Merged
merged 4 commits into from Jan 24, 2022
Merged

Add TrackableFilter interface #4410

merged 4 commits into from Jan 24, 2022

Commits on Jan 21, 2022

  1. add kio filter interface 

    This interface is an extension of the Filter interface which can be used
for filters which are capable of tracking which fields they mutate.
    @sdowell
    sdowell committed Jan 21, 2022
    Copy the full SHA
    fe5cabe View commit details
    Browse the repository at this point in the history

  2. add TrackableSetter struct to filtersutil 

    This struct provides an abstraction to help Filters implement the
TrackableFilter interface
    @sdowell
    sdowell committed Jan 21, 2022
    Copy the full SHA
    8cc46c9 View commit details
    Browse the repository at this point in the history

  3. implement TrackableFilter with annotations 

    This updates the annotations filter to implement the TrackableFilter
interface by reusing the TrackableSetter abstraction provided by
filtersutil.

This is done to provide a generic and consistent experience across the
filters
    @sdowell
    sdowell committed Jan 21, 2022
    Copy the full SHA
    751722d View commit details
    Browse the repository at this point in the history

  4. implement TrackableFilter with labels 

    This updates the labels filter to implement the TrackableFilter
interface by reusing the TrackableSetter abstraction provided by
filtersutil.

This is done to provide a generic and consistent experience across the
filters
    @sdowell
    sdowell committed Jan 21, 2022
    Copy the full SHA
    929334c View commit details
    Browse the repository at this point in the history