Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image name parsing with tag and digest #4406

Merged
merged 5 commits into from Feb 16, 2022

Commits on Jan 20, 2022

  1. Fix image name parsing with name and digest

    Image names may contain both tag name and digest.  For example
    `nginx:1.21.5@sha256:7826426c9d8d310c62fc68bcd5e8dde70cb39d4fbbd30eda3b1bd03e35fbde29`. Kustomizations with image transforms will not match
    these image because the image parser assumes either a tag or digest, but not
    both.
    
    For a real life example of kuberenetes deployments that might need to perform
    these types of transforms is from the [tekton-pipelines](https://github.com/tektoncd/pipeline) project (see the release.yaml).
    cronik committed Jan 20, 2022
    Copy the full SHA
    7a3c426 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. Return digest property from image name parser

    image.Split now returns 3 fields: name, tag, and digest. The tag and digest
    fields no longer include their respective delimiters (`:` and `@`).
    cronik committed Jan 22, 2022
    Copy the full SHA
    727093f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Copy the full SHA
    a62a229 View commit details
    Browse the repository at this point in the history
  2. Fix merge file indentation

    cronik committed Jan 26, 2022
    Copy the full SHA
    1bac439 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    11d585e View commit details
    Browse the repository at this point in the history