Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cobra for better zsh support #4310

Merged
merged 1 commit into from Dec 23, 2021

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Nov 26, 2021

kustomize build ... does not complete file paths on ZSH.

It will with this upgrade.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @sylr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 26, 2021
@sylr sylr force-pushed the upgrade-cobra branch 2 times, most recently from 29118e5 to 5e5f7bd Compare November 26, 2021 21:40
@sylr
Copy link
Contributor Author

sylr commented Dec 8, 2021

@natasha41575 could you merge this please ?

@sylr
Copy link
Contributor Author

sylr commented Dec 17, 2021

@natasha41575 ?

@natasha41575
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 21, 2021
@KnVerey
Copy link
Contributor

KnVerey commented Dec 23, 2021

I was initially very wary of all the new dependencies this pulls in, but I see that kubectl has already merged the same upgrade (and indeed already had most of the dependencies in question from other sources before the upgrade): kubernetes/kubernetes#103448.

PR needs rebase before LGTM.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, sylr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2021
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
@sylr
Copy link
Contributor Author

sylr commented Dec 23, 2021

@KnVerey rebased

@KnVerey
Copy link
Contributor

KnVerey commented Dec 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1843b6f into kubernetes-sigs:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants