Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "Result" errors as non-fatal errors in kyaml FilterFuncs #4241

Merged
merged 2 commits into from Nov 22, 2021

Commits on Nov 11, 2021

  1. Handle kyaml Filter errors type Result as non-breaking errors and sto…

    …re in ResourceList
    
    - Result can only count as error when passed as pointer, this makes easy use of "errors.As"
    - Existing Filter() implementations that return Result from the `framework` package won't return an error anymore but modify the ResourceList
    Carlos Ortiz García committed Nov 11, 2021
    Copy the full SHA
    894ffec View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. fix typo

    Co-authored-by: Katrina Verey <kn.verey@gmail.com>
    Goodwine and KnVerey committed Nov 12, 2021
    Copy the full SHA
    4cde50a View commit details
    Browse the repository at this point in the history