Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard Kubernetes project roles for ownership #4185

Merged

Conversation

KnVerey
Copy link
Contributor

@KnVerey KnVerey commented Sep 15, 2021

  • Let's use the standard community roles instead of the GIthub permissions names.
  • Separate "reviewers" list with just folks who actively review to make sure PRs get seen.
  • New owners group for kyaml (and cmd/config), which in practice has different folks focussing on it.
  • Updates to reflect who is actively involved in what, to the best of my understanding (please correct me)

/cc @monopole @natasha41575 @mengqiy @phanimarupaka @mortent @Shell32-Natsu
If you're not where you think you should be, just say so and I'll fix it.

See https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md for how these files work

ALLOW_MODULE_SPAN

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@yuwenma
Copy link
Contributor

yuwenma commented Sep 15, 2021

I'd like to nominate @natasha41575 in the approver list considering her continuous contribution in kustomize @monopole @KnVerey WDYT?

Besides, may I be added to the kustomize-reviewers list so as I can "automatically pinged on PRs"?
Here's the PR I'm working on and looking into. #4180 #4124

@KnVerey
Copy link
Contributor Author

KnVerey commented Sep 16, 2021

Don't worry, Natasha is already an approver and this PR doesn't change it. 😄
Please note that all top-level reviewers/approvers implicitly have the same status on kyaml.

I would love to add you as a reviewer @yuwenma but you'll need to join the kubernetes-sigs org first. 😄

@KnVerey
Copy link
Contributor Author

KnVerey commented Sep 16, 2021

/retest

@natasha41575
Copy link
Contributor

/lgtm

@mengqiy @phanimarupaka @mortent If you find that you don't have the permissions you need to contribute please let us know and we can correct it for you.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit c6cb42e into kubernetes-sigs:master Sep 20, 2021
@KnVerey KnVerey deleted the standardize_owners_files branch September 21, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants