Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix 4124] Skip local resource until all transformations have completed. #4180

Merged
merged 2 commits into from Sep 24, 2021
Merged

[Fix 4124] Skip local resource until all transformations have completed. #4180

merged 2 commits into from Sep 24, 2021

Commits on Sep 16, 2021

  1. [Fix 4124] Add unittest with the given example.

    @yuwenma
    yuwenma committed Sep 16, 2021
    Copy the full SHA
    a100dca View commit details
    Browse the repository at this point in the history

  2. [fix 4124] Skip local resource until all transformations have completed. 

    Resources annotated as "local-config" are expected to be ignored. This skip local resource happens in "accumulateResources" which happens before any transformation operations.
However, the local resource may be needed in transformations.
Thus, this change removes the "drop local resource" logic from accumulateResources and removes these local resource after all transformation operations and var operations are done.

Note:
None of the existing ResMap functions can drop the resource slice easily: "Clear" will ruin the resource order, "AppendAll" only adds non-existing resource, "AbsorbAll" only add or modify but not delete.
Thus, we introduce a new func "Intersection" for resourceAccumulator that specificaly removes the resource by ID and keep the original order.
    @yuwenma
    yuwenma committed Sep 16, 2021
    Copy the full SHA
    f438273 View commit details
    Browse the repository at this point in the history