Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacements: fix issue with create: true option when there is an existing field #4667

Merged
merged 5 commits into from Jul 15, 2022
Merged

replacements: fix issue with create: true option when there is an existing field #4667

merged 5 commits into from Jul 15, 2022

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Jun 7, 2022 •
edited

First commit demonstrates the bug, second one fixes it. Likely caused by #4424. Follow up to this review comment #4577 (comment).
LookupCreate seems to do weird things if the field already exists. So the logic here is just: if the field already exists, don't use LookupCreate.

/cc @KnVerey @yuwenma

@k8s-ci-robot
Copy link
Contributor

@natasha41575: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2022
@natasha41575 natasha41575 force-pushed the replacementsBug branch 2 times, most recently from 51f9a82 to ff1c2a2 Compare June 8, 2022 00:01
@natasha41575 natasha41575 mentioned this pull request Jun 8, 2022
Merged
@natasha41575
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 8, 2022
@yuwenma
Copy link
Contributor

yuwenma commented Jun 8, 2022

PR looks good and the logic is straight forward to me. Defer to @KnVerey to approve.

KnVerey
KnVerey reviewed Jun 10, 2022
View reviewed changes
api/filters/replacement/replacement_test.go Outdated Show resolved Hide resolved
api/filters/replacement/replacement.go Outdated Show resolved Hide resolved
@koba1t
Copy link
Member

koba1t commented Jun 22, 2022 •
edited

Hi
I opened #4608 to fix #4577 (review)
I think the above PR is related to this.

Could you check it?
And, Can I help you?

@natasha41575 natasha41575 mentioned this pull request Jun 22, 2022
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2022
KnVerey
KnVerey suggested changes Jul 5, 2022
View reviewed changes
api/filters/replacement/replacement.go Outdated Show resolved Hide resolved
api/filters/replacement/replacement.go Outdated Show resolved Hide resolved
api/filters/replacement/replacement.go Outdated Show resolved Hide resolved
api/filters/replacement/replacement.go Outdated Show resolved Hide resolved
@KnVerey
Copy link
Contributor

KnVerey commented Jul 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2f2ba40 into kubernetes-sigs:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma Awaiting requested review from yuwenma

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees

@KnVerey KnVerey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@natasha41575 @k8s-ci-robot @yuwenma @koba1t @KnVerey