Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Expand documentation of annotations used in manifests and KRM functio…
…ns API (#3995) * Expand documentation of annotations used in manifests and KRM function wire format. - Reserve `internal.config.kubernetes.io` for control annotations - Document `local-config` annotation in a seperate document (It's orthogonal to KRM functions). - There is a internal annotation that uses `config.k8s.io` instead of `config.kubernetes.io` used by other annotations. See [1] and [2]. We should avoid using two seperate annotation prefixes and audit the codebase for any other annotation. Given the `id` control annotation is used for comment preservation (no existing function should be modifying it), I suggest moving this over to use `fn-ctrl.config.kubernets.io/id`. [1]: https://github.com/kubernetes-sigs/kustomize/blob/7e8ba62e9fd9c9b9635598008b933f30f988452f/kyaml/fn/runtime/runtimeutil/runtimeutil.go#L195 [2]: #2465 * Move path/index annotation to use internal prefix * Clarify MUST NOT vs SHOULD NOT for internal annotations * Update cmd/config/docs/api-conventions/functions-spec.md Co-authored-by: Katrina Verey <kn.verey@gmail.com> * Update cmd/config/docs/api-conventions/functions-spec.md Co-authored-by: Katrina Verey <kn.verey@gmail.com> * Update cmd/config/docs/api-conventions/manifest-annotations.md Co-authored-by: Katrina Verey <kn.verey@gmail.com> * Remove kusotmization as example Co-authored-by: Katrina Verey <kn.verey@gmail.com>
- Loading branch information