works where stringvalue makes sense but not replicacount

kubernetes-sigs · Feb 2, 2022 · 0c05a1b · 0c05a1b
1 parent 5fd2221
commit 0c05a1b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/kyaml/yaml/fns.go b/kyaml/yaml/fns.go
@@ -638,7 +638,7 @@ type FieldSetter struct {
 
 func (s FieldSetter) Filter(rn *RNode) (*RNode, error) {
 	if s.StringValue != "" && s.Value == nil {
-		s.Value = NewScalarRNode(s.StringValue)
+		s.Value = NewStringRNode(s.StringValue)
 	}
 
 	if s.Name == "" {

diff --git a/kyaml/yaml/rnode.go b/kyaml/yaml/rnode.go
@@ -110,6 +110,9 @@ func NewScalarRNode(value string) *RNode {
 func NewStringRNode(value string) *RNode {
 	n := yaml.Node{Kind: yaml.ScalarNode}
 	n.SetString(value)
+	if IsValueNonString(n.Value) {
+		n.Style = yaml.DoubleQuotedStyle
+	}
 	return NewRNode(&n)
 }