Add validation to ResourceFlavor and consider references to ClusterQueue

[xiaoxubeii]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add validation of updates to ClusterQueue references for ResourceFlavor to prevent data inconsistencies during Quota in ClusterQueue.

Which issue(s) this PR fixes:

Fixes #167

Special notes for your reviewer:

[k8s-ci-robot]

Welcome @xiaoxubeii!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @xiaoxubeii. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaoxubeii
To complete the pull request process, please assign denkensk after the PR has been reviewed.
You can assign the PR to them by writing /assign @denkensk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kerthcet]

/ok-to-test

[kerthcet]

Do you have special reasons to update the dependences?

[xiaoxubeii]

I need PR kubernetes-sigs/controller-runtime#1765 to fix delete validation error in ClusterQueue.

[ArangoGutierrez]

I am concerned that this will introduce a major bump in the overall project. right now we have 1.22 in the docs as the minimum dependency. and users running v0.1 and v0.1.1 will expect this to be true at least for a couple more versions. so raising the bar to 1.24 before V0.2 is not a viable option IMO

[xiaoxubeii]

OK, maybe I can first remove the codes that depends on controller-runtime master and wait until upgrade later.

[k8s-ci-robot]

@xiaoxubeii: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kueue-verify-main	d77ef1a	link	true	/test pull-kueue-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[xiaoxubeii]

/hold

[k8s-ci-robot]

@xiaoxubeii: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

As per discussion in #167 (comment), we are leaving this kind of validation for later.

However, I don't think we want to maintain the list of ClusterQueues in the ResourceFlavor object. We should probably just check in a webhook for ClusterQueue.

/close

Feel free to work on this once we have figured if #167 can be implemented as discussed in #167 (comment)

[k8s-ci-robot]

@alculquicondor: Closed this PR.

In response to this:

As per discussion in #167 (comment), we are leaving this kind of validation for later.

However, I don't think we want to maintain the list of ClusterQueues in the ResourceFlavor object. We should probably just check in a webhook for ClusterQueue.

/close

Feel free to work on this once we have figured if #167 can be implemented as discussed in #167 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.