Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GO to 1.18 #122

Merged
merged 1 commit into from Mar 21, 2022
Merged

Bump GO to 1.18 #122

merged 1 commit into from Mar 21, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g March 16, 2022 13:58
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 16, 2022
@alculquicondor
Copy link
Contributor

I guess prow doesn't support it yet :)

@ArangoGutierrez ArangoGutierrez changed the title Bump GO to 1.18 WIP: Bump GO to 1.18 Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

prow is not so edgy
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

Side PR -> kubernetes/test-infra#25653

@ArangoGutierrez
Copy link
Contributor Author

/retest-required

@ArangoGutierrez
Copy link
Contributor Author

/test pull-kueue-verify-main

@ArangoGutierrez
Copy link
Contributor Author

prow is ignoring me....

@ArangoGutierrez
Copy link
Contributor Author

/hold cancel

1 similar comment
@ArangoGutierrez
Copy link
Contributor Author

/hold cancel

@ArangoGutierrez ArangoGutierrez changed the title WIP: Bump GO to 1.18 Bump GO to 1.18 Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

/retest-required

1 similar comment
@ArangoGutierrez
Copy link
Contributor Author

/retest-required

@ArangoGutierrez
Copy link
Contributor Author

golangci/golangci-lint#2649

@ArangoGutierrez
Copy link
Contributor Author

kubernetes/test-infra#25657

@ArangoGutierrez
Copy link
Contributor Author

/test pull-kueue-verify-main

@alculquicondor
Copy link
Contributor

Why do you want to merge this now? If we can't run verify on 1.18, there is not much point in upgrading yet.

@ArangoGutierrez
Copy link
Contributor Author

Why do you want to merge this now? If we can't run verify on 1.18, there is not much point in upgrading yet.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2022
@ArangoGutierrez ArangoGutierrez changed the title Bump GO to 1.18 WIP: Bump GO to 1.18 Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2022
@ArangoGutierrez ArangoGutierrez marked this pull request as draft March 16, 2022 20:43
@ArangoGutierrez
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022
@ArangoGutierrez ArangoGutierrez marked this pull request as ready for review March 18, 2022 21:57
@ArangoGutierrez
Copy link
Contributor Author

https://github.com/golangci/golangci-lint/releases/tag/v1.45.0 adds support for go1.18, we are good to go

@ArangoGutierrez
Copy link
Contributor Author

@ArangoGutierrez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-verify-main 5d7f3a4 link true /test pull-kueue-verify-main
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

we can now bump on test-infra :)

@ArangoGutierrez ArangoGutierrez mentioned this pull request Mar 18, 2022
Merged
@ArangoGutierrez ArangoGutierrez changed the title WIP: Bump GO to 1.18 Bump GO to 1.18 Mar 18, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2022
alculquicondor
alculquicondor reviewed Mar 21, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez force-pushed the devel/go_118 branch 3 times, most recently from 5e38c09 to 7162e68 Compare March 21, 2022 16:03
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2022
@ArangoGutierrez
Bump GO to 1.18
22d2f71 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Copy link
Contributor Author

@ArangoGutierrez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-verify-main 22d2f71 link true /test pull-kueue-verify-main
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Fix is kubernetes/test-infra#25690

@alculquicondor
Copy link
Contributor

/retest
/hold cancel

@alculquicondor
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 851c3c1 into kubernetes-sigs:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArangoGutierrez @alculquicondor @k8s-ci-robot