Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch schemas at runtime #67

Merged
merged 14 commits into from
Sep 14, 2023
Merged

fix: patch schemas at runtime #67

merged 14 commits into from
Sep 14, 2023

Conversation

eddycharly
Copy link
Contributor

This PR patches schemas at runtime in the factory.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2023
alexzielenski
alexzielenski reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@alexzielenski alexzielenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good approach. Requested some checks to be added to make sure CRDs dont get broken

pkg/validatorfactory/schema_patcher.go Show resolved Hide resolved
pkg/validatorfactory/schema_patcher.go Outdated Show resolved Hide resolved
pkg/validatorfactory/schema_patcher.go Outdated Show resolved Hide resolved
pkg/validatorfactory/factory.go Show resolved Hide resolved
pkg/validatorfactory/factory.go Show resolved Hide resolved
pkg/validatorfactory/schema_patcher.go Show resolved Hide resolved
@eddycharly eddycharly mentioned this pull request Aug 29, 2023
Open
@eddycharly eddycharly mentioned this pull request Aug 31, 2023
Merged
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/contains-merge-commits and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 1, 2023
@eddycharly
Copy link
Contributor Author

@alexzielenski i updated with your changes from #69, PTAL

@eddycharly
fix: patch schemas at runtime
9e3af3d 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
alexzielenski
alexzielenski reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@alexzielenski alexzielenski left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, I would like to see a test to confirm this change fixes the problem it is intended to fix

@eddycharly
Copy link
Contributor Author

@alexzielenski I added a unit test to verify it solves the issue we were facing.

@eddycharly
unit test
6e34d76 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
alexzielenski
alexzielenski requested changes Sep 13, 2023
View reviewed changes
pkg/validatorfactory/factory_test.go Outdated
typed interface{}
want interface{}
}{{
name: "configmap",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests the change against a native type ConfigMap, but I thought the motivating example for this change was with CRDs so I expected to see a test for a CRD.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh OK, i did just that in kyverno/kyverno#8384, i will make the same test here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a unit test with a crd

pkg/validatorfactory/factory_test.go Outdated Show resolved Hide resolved
@eddycharly
crd unit test
1e53df7 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2023
alexzielenski
alexzielenski approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@alexzielenski alexzielenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, eddycharly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@alexzielenski
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 14, 2023
@alexzielenski
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 34b6c09 into kubernetes-sigs:main Sep 14, 2023
5 checks passed
@eddycharly eddycharly deleted the fix-schemas-at-runtime branch September 14, 2023 05:56
@eddycharly
Copy link
Contributor Author

Awesome ! Thank you @alexzielenski 🙏

@alexzielenski alexzielenski mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzielenski alexzielenski alexzielenski approved these changes

@apelisse apelisse Awaiting requested review from apelisse

@richabanker richabanker Awaiting requested review from richabanker

Assignees

@alexzielenski alexzielenski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eddycharly @k8s-ci-robot @alexzielenski