added a new unit test case #2752
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
kind/test
do-not-merge/release-note-label-needed
|
|
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @soravkumarsharma! |
k8s-ci-robot
added
needs-ok-to-test
|
Hi @soravkumarsharma. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: soravkumarsharma The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
| name: "verifying the contents of a GatewayRef with nil listener names", | ||
| nsn: types.NamespacedName{Namespace: corev1.NamespaceDefault, Name: "fake-gateway"}, | ||
| // nil listenerNames | ||
| listenerNames: nil, |
There was a problem hiding this comment.
In Golang the zero value of a slice is nil, so this is equivalent to the first test case which omits the value entirely.
| } | ||
|
|
||
| for i := 0; i < len(tests); i++ { | ||
| test := tests[i] | ||
| t.Run(test.name, func(t *testing.T) { | ||
| ref := NewGatewayRef(test.nsn, test.listenerNames...) | ||
| require.IsType(t, GatewayRef{}, ref) | ||
| if test.listenerNames == nil { | ||
| if test.listenerNames == nil || len(test.listenerNames) == 0 { |
There was a problem hiding this comment.
So looking through the code it does appear that we treat a nil or empty slice of listenerNames the same (by appending a single "empty" listenerName (which in retrospect I'm a little weirded out by, but for the sake of the test let's roll with it for a moment)), but in this test we treat it differently: if you were to provided a non-nil empty list of names you would get an appended "empty" name, which prior to this change would actually fail because it would jump to the next block and panic?
So I think this change makes sense, but in your test above you should provide a non-nil empty slice (e.g. []string{}) instead.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
@soravkumarsharma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind test
What this PR does / why we need it:
In the context of NewGatewayRef function, having a nil test case allows you to verify that the function correctly handles nil values for the listenerNames parameter. If function is designed to handle nil values by providing some default behavior, this test case ensures that the default behavior is working as intended.
Which issue(s) this PR fixes:
If NewGatewayRef function is expected to provide default values or behavior when the listenerNames parameter is nil, the test case helps ensure that the defaults are correctly applied.
Fixes #
Does this PR introduce a user-facing change?:
NONE