Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert observedGeneration is incremented in Status.Conditions. #1586

Merged
merged 22 commits into from Dec 19, 2022
Merged

Assert observedGeneration is incremented in Status.Conditions. #1586

merged 22 commits into from Dec 19, 2022

Commits on Dec 8, 2022

  1. Update helpers so they check conditions when they are up to date 

    Prior when asserting against conditions the helpers didn't check their
observedGeneration. This means the assertions could occur with a stale
status.
    @dprotaso
    dprotaso committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d5aebb9 View commit details
    Browse the repository at this point in the history

  2. When updating Gateway status conditions should increment their observ… 

    …edGeneration
    @dprotaso
    dprotaso committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    6873420 View commit details
    Browse the repository at this point in the history

  3. allow injection of controllerNames

    @dprotaso
    dprotaso committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0e5ed4c View commit details
    Browse the repository at this point in the history

  4. When updating GatewayClass the status conditions should increment the… 

    …ir observedGeneration
    @dprotaso
    dprotaso committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5658f1d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. fix casing of t.Error/Fatal messages

    @dprotaso
    dprotaso committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3fbe62e View commit details
    Browse the repository at this point in the history

  2. removed pasted link

    @dprotaso
    dprotaso committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b58b45f View commit details
    Browse the repository at this point in the history

  3. refactor some helpers to assert observedGeneration is bumped

    @dprotaso
    dprotaso committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    009e835 View commit details
    Browse the repository at this point in the history

  4. add HTTPRoute observed generation tests

    @dprotaso
    dprotaso committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    de2d9c5 View commit details
    Browse the repository at this point in the history

  5. use a unique port when adding a new listener

    @dprotaso
    dprotaso committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    db554da View commit details
    Browse the repository at this point in the history

  6. increase test timeout to a minute

    @dprotaso
    dprotaso committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    6582754 View commit details
    Browse the repository at this point in the history

  7. use real backends

    @dprotaso
    dprotaso committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c8f4c5d View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. fail test is an unexpected parent ref appears

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    546ad16 View commit details
    Browse the repository at this point in the history

  2. Provide better error messages for failed assertions

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    0b9d064 View commit details
    Browse the repository at this point in the history

  3. fix fixture name

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    ec9c9ca View commit details
    Browse the repository at this point in the history

  4. fix stale count logging

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    9441114 View commit details
    Browse the repository at this point in the history

  5. create a deep copy prior to mutation and updating

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    f87815b View commit details
    Browse the repository at this point in the history

  6. drop redundant assertions 

    *MustHaveLatestConditions will ensure the observedGeneration has changed
    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    3e97ba4 View commit details
    Browse the repository at this point in the history

  7. address linting

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    46fb65d View commit details
    Browse the repository at this point in the history

  8. use assertion helper

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    41f9802 View commit details
    Browse the repository at this point in the history

  9. log only the parent ref name

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    e2ca2e9 View commit details
    Browse the repository at this point in the history

  10. update godoc

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c73eadb View commit details
    Browse the repository at this point in the history

  11. put the gateway class observed gen bump behind a support flag

    @dprotaso
    dprotaso committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    759598d View commit details
    Browse the repository at this point in the history