Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook: validate at least one of GRPCRoute.Rules.Matches.{Method,Service} is supplied #1490

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Webhook: validate at least one of GRPCRoute.Rules.Matches.{Method,Service} is supplied #1490

merged 3 commits into from
Nov 3, 2022

Conversation

gyohuangxin
Copy link
Member

@gyohuangxin gyohuangxin commented Oct 28, 2022 •
edited

What type of PR is this?

/kind feature
What this PR does / why we need it:

  • Initial GRPCRoute apis validations
  • Add a validation to validate that at least one of the fields Service and Method of GRPCMethodMatch to be specified

Which issue(s) this PR fixes:

Fixes #1098

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @gyohuangxin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2022
@gyohuangxin
Webhook: validate at least one of GRPCRoute.Rules.Matches.{Method,Ser…
ebf32d3 
…vice} is supplied

Signed-off-by: Huang Xin <xin1.huang@intel.com>
@gyohuangxin
Copy link
Member Author

@robscott Can you help review this? Thanks

shaneutt
shaneutt approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll wait for Rob or Nick to give it a final pass 👍

apis/v1alpha2/validation/grpcroute.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@gyohuangxin
Fix typos
d9074e5 
Signed-off-by: Huang Xin <xin1.huang@intel.com>
@robscott
Copy link
Member

robscott commented Nov 3, 2022

/ok-to-test
/cc @gnossen

@k8s-ci-robot
Copy link
Contributor

@robscott: GitHub didn't allow me to request PR reviews from the following users: gnossen.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/ok-to-test
/cc @gnossen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2022
@robscott
Copy link
Member

robscott commented Nov 3, 2022

This LGTM, will give @gnossen some time to review.

/approve

@gyohuangxin
Copy link
Member Author

/retest

@gyohuangxin
Copy link
Member Author

@shaneutt @robscott Thanks for your reviews. Can I join the Kubernetes-sig org to contribute and test more easily? If yes, would you like to be my sponsors?

@gyohuangxin
Fix format issues
77e65a2 
Signed-off-by: Huang Xin <xin1.huang@intel.com>
gnossen
gnossen approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the help on this!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnossen, gyohuangxin, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

robscott commented Nov 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit bd49fb3 into kubernetes-sigs:main Nov 3, 2022
@robscott
Copy link
Member

robscott commented Nov 3, 2022

Hey @gyohuangxin, I'll sponsor you to join the k-sigs org, thanks for all your contributions!

@shaneutt
Copy link
Member

shaneutt commented Nov 3, 2022

@gyohuangxin, yep I will too 👍

@gyohuangxin gyohuangxin mentioned this pull request Nov 4, 2022
Closed
9 tasks
@gyohuangxin
Copy link
Member Author

gyohuangxin commented Nov 4, 2022 •
edited

@robscott @shaneutt Thank you so much! Please leave "+1" comment here: kubernetes/org#3817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnossen gnossen gnossen approved these changes

@shaneutt shaneutt shaneutt approved these changes

@bowei bowei Awaiting requested review from bowei

@youngnick youngnick Awaiting requested review from youngnick

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate At Least One of GRPCRoute.Rules.Matches.{Method,Service} is Supplied
5 participants
@gyohuangxin @k8s-ci-robot @robscott @shaneutt @gnossen