Update ParentRef wording #1594
Merged
Update ParentRef wording #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
approved
|
I didn't update the v1alpha2 docs; happy to if we think that's worthwhile for this change. |
k8s-ci-robot
added
size/S
|
Rebased and updated, PTAL. |
|
Thanks @youngnick! LGTM once tests pass. |
shaneutt
reviewed
Dec 19, 2022
apis/v1alpha2/shared_types.go
Outdated
Comment on lines
28
to
32
| // Note that for ParentRefs that cross namespace boundaries, there are specific | ||
| // rules. Cross-namespace references are only valid if they are explicitly | ||
| // allowed by something in the namespace they are referring to. For example, | ||
| // Gateway has the AllowedRoutes field, and ReferenceGrant provides a | ||
| // generic way to enable any other kind of cross-namespace reference. |
There was a problem hiding this comment.
Suggested change
| // Note that for ParentRefs that cross namespace boundaries, there are specific | |
| // rules. Cross-namespace references are only valid if they are explicitly | |
| // allowed by something in the namespace they are referring to. For example, | |
| // Gateway has the AllowedRoutes field, and ReferenceGrant provides a | |
| // generic way to enable any other kind of cross-namespace reference. | |
| // Note that for ParentRefs that cross namespace boundaries there are specific | |
| // rules. Cross-namespace references are only valid if they are explicitly | |
| // allowed by something in the namespace they are referring to. For example: | |
| // Gateway has the AllowedRoutes field, and ReferenceGrant provides a | |
| // generic way to enable any other kind of cross-namespace reference. |
youngnick
force-pushed
the
973-fix
branch
2 times, most recently
from
5e072be
to
f11a606
Compare
…ceGrant Signed-off-by: Nick Young <nick@isovalent.com>
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaneutt, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Notes that ParentRefs that cross namespace boundaries must have some way for the referent to accept/allow the routes.
Which issue(s) this PR fixes:
Fixes #973
Does this PR introduce a user-facing change?: