Skip to content

Commit

Permalink
Update wording on ParentRef field to require AllowedRoutes or Referen…
Browse files Browse the repository at this point in the history
…ceGrant

Signed-off-by: Nick Young <nick@isovalent.com>
  • Loading branch information
youngnick committed Dec 20, 2022
1 parent 9c9429a commit f11a606
Show file tree
Hide file tree
Showing 8 changed files with 170 additions and 24 deletions.
6 changes: 6 additions & 0 deletions apis/v1alpha2/shared_types.go
Expand Up @@ -25,6 +25,12 @@ import (
// with "Core" support is Gateway. This API may be extended in the future to
// support additional kinds of parent resources, such as HTTPRoute.
//
// Note that there are specific rules for ParentRefs that cross namespace
// boundaries. Cross-namespace references are only valid if they are explicitly
// allowed by something in the namespace they are referring to. For example:
// Gateway has the AllowedRoutes field, and ReferenceGrant provides a
// generic way to enable any other kind of cross-namespace reference.
//
// The API object must be valid in the cluster; the Group and Kind must
// be registered in the cluster for this reference to be valid.
// +k8s:deepcopy-gen=false
Expand Down
12 changes: 12 additions & 0 deletions apis/v1beta1/shared_types.go
Expand Up @@ -52,6 +52,12 @@ type ParentReference struct {
// Namespace is the namespace of the referent. When unspecified, this refers
// to the local namespace of the Route.
//
// Note for ParentRefs that cross namespace boundaries there are specific
// rules. Cross-namespace references are only valid if they are explicitly
// allowed by something in the namespace they are referring to. For example:
// Gateway has the AllowedRoutes field, and ReferenceGrant provides a
// generic way to enable any other kind of cross-namespace reference.
//
// Support: Core
//
// +optional
Expand Down Expand Up @@ -140,6 +146,12 @@ type CommonRouteSpec struct {
// case, the list of routes attached to those resources should also be
// merged.
//
// Note that for ParentRefs that cross namespace boundaries, there are specific
// rules. Cross-namespace references are only valid if they are explicitly
// allowed by something in the namespace they are referring to. For example,
// Gateway has the AllowedRoutes field, and ReferenceGrant provides a
// generic way to enable any other kind of cross-namespace reference.
//
// +optional
// +kubebuilder:validation:MaxItems=32
ParentRefs []ParentReference `json:"parentRefs,omitempty"`
Expand Down
22 changes: 19 additions & 3 deletions config/crd/experimental/gateway.networking.k8s.io_grpcroutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 38 additions & 6 deletions config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 19 additions & 3 deletions config/crd/experimental/gateway.networking.k8s.io_tcproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 19 additions & 3 deletions config/crd/experimental/gateway.networking.k8s.io_tlsroutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 19 additions & 3 deletions config/crd/experimental/gateway.networking.k8s.io_udproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f11a606

Please sign in to comment.