Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote ReferenceGrant to Beta #1455

Merged
merged 9 commits into from Nov 5, 2022
Merged

Promote ReferenceGrant to Beta #1455

merged 9 commits into from Nov 5, 2022

Conversation

nathancoleman
Copy link
Contributor

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:
Graduates the ReferenceGrant resource to v1beta1 and the stable release channel

Which issue(s) this PR fixes:

Fixes #1448

Does this PR introduce a user-facing change?:

Promotes ReferenceGrant to the v1beta1 API and the stable release channel

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 12, 2022
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @nathancoleman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nathancoleman nathancoleman changed the title Reference grant beta Promote ReferenceGrant to Beta Oct 12, 2022
@robscott
Copy link
Member

Thanks for working on this @nathancoleman! I'm going to hold off on reviewing this since it's still in draft state, but leave another comment here when it's ready for review.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2022
@nathancoleman nathancoleman marked this pull request as ready for review October 17, 2022 21:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2022
@nathancoleman
Copy link
Contributor Author

@robscott can you take a look when you get a moment?

robscott
robscott reviewed Oct 23, 2022
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this @nathancoleman!

hack/invalid-examples/v1alpha2/referencegrant/missing-from.yaml Outdated Show resolved Hide resolved
examples/experimental/reference-grant.yaml Show resolved Hide resolved
examples/experimental/tls-cert-cross-namespace.yaml Show resolved Hide resolved
config/crd/experimental/gateway.networking.k8s.io_referencegrants.yaml
Comment on lines +266 to +267
served: true
storage: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling this out to be sure it's noticed. This approach makes sense to me and matches what we did for other resources as they initially graduated to beta.

apis/v1beta1/referencegrant_types.go Show resolved Hide resolved
@nathancoleman
Use type aliases for ReferenceGrant types in apis/v1alpha2
d6b8f56 
This follows the pattern established by Gateway, HTTPRoute, etc. Specifically, the ReferenceGrantList type is not an alias since it needs to be able to specify the type of `Items` directly.
@nathancoleman nathancoleman requested review from robscott and removed request for bowei, keithmattix, shaneutt and youngnick October 31, 2022 15:49
@nathancoleman
Copy link
Contributor Author

Others feel free to review. It seems that re-requesting a review from Rob removes all other reviewers

@nathancoleman
Copy link
Contributor Author

nathancoleman commented Oct 31, 2022 •
edited

@robscott to you for review when you get a moment

@robscott
Copy link
Member

robscott commented Nov 3, 2022

Thanks @nathancoleman! This change LGTM, but I want to get another maintainer to sign off before merging since this represents graduating a resource to beta.

/approve
/assign @shaneutt @youngnick

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
shaneutt
shaneutt reviewed Nov 4, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to update GEP-709 and mark it as standard as well

@nathancoleman
Copy link
Contributor Author

@shaneutt what change are you looking for there? I don't see anything in the GEP template or other GEPs that looks related

@shaneutt
Copy link
Member

shaneutt commented Nov 4, 2022

You'll wanna update the GEP status here to standard:

gateway-api/site-src/geps/gep-709.md

Line 4 in 2f7ab68

* Status: Experimental

And move it under "Standard" here:

gateway-api/mkdocs.yml

Line 86 in 2f7ab68

- Standard:

Also I would recommend taking one quick pass over the GEP just to make sure everything in it is accurate to the current API state, and if not update it to be in sync.

shaneutt
shaneutt approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nathancoleman, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0b19b47 into kubernetes-sigs:main Nov 5, 2022
@sunjayBhatia sunjayBhatia mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@robscott robscott Awaiting requested review from robscott

Assignees

@shaneutt shaneutt

@youngnick youngnick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promote ReferenceGrant to Beta
5 participants
@nathancoleman @k8s-ci-robot @robscott @shaneutt @youngnick