Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReferenceGrant API version bump has caused Gateway API Conformance to fail on main #4837

Closed
sunjayBhatia opened this issue Nov 7, 2022 · 1 comment · Fixed by #4842
Closed

ReferenceGrant API version bump has caused Gateway API Conformance to fail on main #4837

sunjayBhatia opened this issue Nov 7, 2022 · 1 comment · Fixed by #4842
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API.
Milestone
1.24.0

Comments

@sunjayBhatia
Copy link
Member

sunjayBhatia commented Nov 7, 2022 •
edited

See: kubernetes-sigs/gateway-api#1455

Failing daily build: https://github.com/projectcontour/contour/actions/runs/3410157745

Related:

We could install Gateway API CRDs here using the GATEWAY_API_VERSION variable we use in the Makefile/workflows, or here before where we actually run the tests

In addition we need to move to v1beta1 RBAC etc. in Contour
@sunjayBhatia sunjayBhatia added this to the 1.24.0 milestone Nov 7, 2022
@sunjayBhatia sunjayBhatia added the area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. label Nov 7, 2022
@sunjayBhatia
Copy link
Member Author

Discussed this just now and we're gonna drop the main conformance runs to focus on running conformance against main of GW API to a long-running branch, hoping to track the 0.6.0 release of GW API

@skriss skriss self-assigned this Nov 9, 2022
skriss added a commit to skriss/contour that referenced this issue Nov 9, 2022
@skriss
remove daily Gateway API conformance run
5a258b4 
Going forward, the latest Gateway API conformance
tests will be run in PRs against Contour feature
branches that track the latest Gateway API changes.

Closes projectcontour#4837.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Nov 9, 2022
Merged
skriss added a commit that referenced this issue Nov 9, 2022
@skriss
remove daily Gateway API conformance run (#4842)
8227450 
Going forward, the latest Gateway API conformance
tests will be run in PRs against Contour feature
branches that track the latest Gateway API changes.

Closes #4837.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API.
Projects
Contour
Status: Done
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

remove daily Gateway API conformance run skriss/contour
2 participants
@skriss @sunjayBhatia