PR review feedbacks

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
kubernetes-sigs · Nov 4, 2022 · fa67946 · fa67946
1 parent c50a620
commit fa67946
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/conformance/tests/gateway-invalid-tls-certificateref.go b/conformance/tests/gateway-invalid-tls-certificateref.go
@@ -54,8 +54,8 @@ var GatewayInvalidTLSConfiguration = suite.ConformanceTest{
 			gatewayNamespacedName types.NamespacedName
 		}{
 			{
-				name:                  "Inexistent secret referenced as CertificateRef in a Gateway listener",
-				gatewayNamespacedName: types.NamespacedName{Name: "gateway-certificate-inexistent-secret", Namespace: "gateway-conformance-infra"},
+				name:                  "Nonexistent secret referenced as CertificateRef in a Gateway listener",
+				gatewayNamespacedName: types.NamespacedName{Name: "gateway-certificate-nonexistent-secret", Namespace: "gateway-conformance-infra"},
 			},
 			{
 				name:                  "Unsupported group resource referenced as CertificateRef in a Gateway listener",

diff --git a/conformance/tests/gateway-invalid-tls-certificateref.yaml b/conformance/tests/gateway-invalid-tls-certificateref.yaml
@@ -1,7 +1,7 @@
 apiVersion: gateway.networking.k8s.io/v1beta1
 kind: Gateway
 metadata:
-  name: gateway-certificate-inexistent-secret
+  name: gateway-certificate-nonexistent-secret
   namespace: gateway-conformance-infra
 spec:
   gatewayClassName: "{GATEWAY_CLASS_NAME}"
@@ -16,7 +16,7 @@ spec:
         certificateRefs:
           - group: ""
             kind: Secret
-            name: inexistent-certificate
+            name: nonexistent-certificate
 ---
 apiVersion: gateway.networking.k8s.io/v1beta1
 kind: Gateway
@@ -36,7 +36,7 @@ spec:
         certificateRefs:
           - group: wrong.group.company.io
             kind: Secret
-            name: valid-certificate
+            name: tls-validity-checks-certificate
 ---
 apiVersion: gateway.networking.k8s.io/v1beta1
 kind: Gateway
@@ -56,7 +56,7 @@ spec:
         certificateRefs:
           - group: ""
             kind: WrongKind
-            name: valid-certificate
+            name: tls-validity-checks-certificate
 ---
 apiVersion: gateway.networking.k8s.io/v1beta1
 kind: Gateway
@@ -84,6 +84,8 @@ metadata:
   name: malformed-certificate
   namespace: gateway-conformance-infra
 data:
+  # this certificate is invalid because contains an invalid pem (base64 of "Hello world"),
+  # and the certificate and the key are identical 
   tls.crt: SGVsbG8gd29ybGQK
   tls.key: SGVsbG8gd29ybGQK
 type: kubernetes.io/tls
diff --git a/conformance/utils/suite/suite.go b/conformance/utils/suite/suite.go
@@ -139,7 +139,7 @@ func (suite *ConformanceTestSuite) Setup(t *testing.T) {
 	t.Logf("Test Setup: Applying programmatic resources")
 	secret := kubernetes.MustCreateSelfSignedCertSecret(t, "gateway-conformance-web-backend", "certificate", []string{"*"})
 	suite.Applier.MustApplyObjectsWithCleanup(t, suite.Client, suite.TimeoutConfig, []client.Object{secret}, suite.Cleanup)
-	secret = kubernetes.MustCreateSelfSignedCertSecret(t, "gateway-conformance-infra", "valid-certificate", []string{"*"})
+	secret = kubernetes.MustCreateSelfSignedCertSecret(t, "gateway-conformance-infra", "tls-validity-checks-certificate", []string{"*"})
 	suite.Applier.MustApplyObjectsWithCleanup(t, suite.Client, suite.TimeoutConfig, []client.Object{secret}, suite.Cleanup)
 
 	t.Logf("Test Setup: Ensuring Gateways and Pods from base manifests are ready")