Skip benchmarks if associated resource number is not set.

Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
kubernetes-sigs · May 5, 2022 · 5757376 · 5757376
1 parent 1aa81af
commit 5757376
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/pkg/benchmark/container.go b/pkg/benchmark/container.go
@@ -55,8 +55,8 @@ var _ = framework.KubeDescribe("Container", func() {
 				N:           framework.TestContext.BenchmarkingParams.ContainersNumber,
 				NumParallel: framework.TestContext.BenchmarkingParams.ContainersNumberParallel,
 			}
-			if samplingConfig.N < 1 {
-				samplingConfig.N = 1
+			if samplingConfig.N <= 0 {
+				Skip("skipping container lifecycle benchmarks since container number option was not set")
 			}
 			if samplingConfig.NumParallel < 1 {
 				samplingConfig.NumParallel = 1

diff --git a/pkg/benchmark/image.go b/pkg/benchmark/image.go
@@ -94,8 +94,8 @@ var _ = framework.KubeDescribe("Image", func() {
 				N:           framework.TestContext.BenchmarkingParams.ImagesNumber,
 				NumParallel: framework.TestContext.BenchmarkingParams.ImagesNumberParallel,
 			}
-			if samplingConfig.N < 1 {
-				samplingConfig.N = 1
+			if samplingConfig.N <= 0 {
+				Skip("skipping image lifecycle benchmarks since image number option was not set")
 			}
 			if samplingConfig.NumParallel < 1 {
 				samplingConfig.NumParallel = 1
@@ -187,8 +187,8 @@ var _ = framework.KubeDescribe("Image", func() {
 				N:           framework.TestContext.BenchmarkingParams.ImagesNumber,
 				NumParallel: framework.TestContext.BenchmarkingParams.ImagesNumberParallel,
 			}
-			if samplingConfig.N < 1 {
-				samplingConfig.N = 1
+			if samplingConfig.N <= 0 {
+				Skip("skipping image listing benchmarks since image listing number option was not set")
 			}
 			if samplingConfig.NumParallel < 1 {
 				samplingConfig.NumParallel = 1

diff --git a/pkg/benchmark/pod.go b/pkg/benchmark/pod.go
@@ -54,8 +54,8 @@ var _ = framework.KubeDescribe("PodSandbox", func() {
 				N:           framework.TestContext.BenchmarkingParams.PodsNumber,
 				NumParallel: framework.TestContext.BenchmarkingParams.PodsNumberParallel,
 			}
-			if samplingConfig.N < 1 {
-				samplingConfig.N = 1
+			if samplingConfig.N <= 0 {
+				Skip("skipping pod lifecycle benchmarks since pod number option was not set")
 			}
 			if samplingConfig.NumParallel < 1 {
 				samplingConfig.NumParallel = 1