✨ Add FieldPath and Reason to XValidation marker #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
JoelSpeed
force-pushed
the
complete-xvalidation
branch
from
411a361
to
6fca3f8
Compare
|
/hold testing the output of this to make sure it does what I expect |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel Yep, this is working as intended and I've tested the fieldPath and reason fields separately on a 1.29 KAS |
k8s-ci-robot
removed
the
do-not-merge/hold
vincepri
approved these changes
Apr 24, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
LGTM label has been added. Git tree hash: cef6c895428289da62c4fd93f6ffc54981209bea
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to specify the FieldPath and Reason on an XValidation rule. These can be useful when you are specifying validations that look at multiple fields or if the default reason of Invalid doesn't suit.
One use case would be a field that you no longer want set. You can add a CEL validation to make sure no one adds it to the object going forward. For this you would want the Forbidden reason, but the rule needs to be on the parent, which means you then need to use the field path to construct the correct error message path.