New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Bump golang version to 1.19 #713
✨ Bump golang version to 1.19 #713
Conversation
|
Welcome @darkelf21cn! |
Hi @darkelf21cn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: darkelf21cn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a74be45
to
2e85eed
Compare
/ok-to-test |
2e85eed
to
450b69a
Compare
450b69a
to
962cd49
Compare
@darkelf21cn: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I can reproduce the issue. controller-gen won't run on Go 1.19, because it doesn't understand the new generics directives. |
Closing this one since it seems sorted out in : #722 Feel free to re-open if you see fit. |
Bump golang version to 1.19 to fix errors below.