Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add XPreserveUnknownFields to runtime.RawExtension #703

Merged
merged 3 commits into from Jul 5, 2022
Merged

🐛 Add XPreserveUnknownFields to runtime.RawExtension #703

merged 3 commits into from Jul 5, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #683

/assign FillZpp

@eddycharly
Add XPreserveUnknownFields to runtime.RawExtension
0e9f8de 
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
@eddycharly
fix: tests
4365527 
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
@eddycharly
fix: generate crd manifests
57f256c 
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 5, 2022
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2022
@FillZpp
Copy link
Contributor

FillZpp commented Jul 5, 2022

/lgtm

/cc @eddycharly @alvaroaleman

@k8s-ci-robot
Copy link
Contributor

@FillZpp: GitHub didn't allow me to request PR reviews from the following users: eddycharly.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/lgtm

/cc @eddycharly @alvaroaleman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022
@eddycharly
Copy link
Contributor

/retitle 🐛 Add XPreserveUnknownFields to runtime.RawExtension

@k8s-ci-robot
Copy link
Contributor

@eddycharly: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle 🐛 Add XPreserveUnknownFields to runtime.RawExtension

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2022
@alvaroaleman alvaroaleman changed the title [release-0.9] 🐛 Add XPreserveUnknownFields to runtime.RawExtension bug: Add XPreserveUnknownFields to runtime.RawExtension Jul 5, 2022
@alvaroaleman alvaroaleman changed the title bug: Add XPreserveUnknownFields to runtime.RawExtension 🐛 Add XPreserveUnknownFields to runtime.RawExtension Jul 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit d55cd3d into kubernetes-sigs:release-0.9 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@FillZpp FillZpp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @FillZpp @k8s-ci-robot @eddycharly @alvaroaleman