New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.9] 🐛 Allow setting PreserveUnknownFields at both type and field level #700
Commits on May 25, 2022
-
ci: fix golangci-lint installation
`install.goreleaser.com` is now deprecated and stopped working so the tests in new PRs are failing.
Configuration menu - View commit details
-
Copy full SHA for edb8efc - Browse repository at this point
Copy the full SHA edb8efcView commit details -
Merge pull request kubernetes-sigs#682 from ahmetb/fix-test
🐛 ci: fix golangci-lint installation
Configuration menu - View commit details
-
Copy full SHA for f89071a - Browse repository at this point
Copy the full SHA f89071aView commit details
Commits on May 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4fefd28 - Browse repository at this point
Copy the full SHA 4fefd28View commit details
Commits on May 31, 2022
-
🐛 crdgen: compare metav1 pkg by ID (kubernetes-sigs#681)
* crdgen: compare metav1 pkg by ID & fsp loader This patch updates the way the CRD generator compares an imported metav1 package. Previously the comparison occurred using a Golang equality operator, !=, against two, in-memory data structures. However, this fails when multiple root paths are loaded. Their metav1 packages are identical, just not identical objects in memory. This patch updates the comparison to compare the package IDs, not the instance of the object. This patch also introduces a filesystem-path specific loader for each unique filesystem path provided as a root. This ensures the AST is loaded correctly and the kubebuilder markers are parsed as intended. * Reproduce the issue This patch adds tests to reproduce the issue of the markers not being discovered when multiple paths are used. The issue is not markers missing from a type, but markers missing from a *referenced* type. For example, the new Job type imports the unserved.CronJobSpec as the field Job.Spec.CronJob. The markers are not generated for Job.Spec.CronJob as it is referenced from another package.
Configuration menu - View commit details
-
Copy full SHA for ea90e81 - Browse repository at this point
Copy the full SHA ea90e81View commit details
Commits on Jun 1, 2022
-
Simplify the LoadRootsWithConfig logic
This patch simplifies the LoadRootsWithConfig logic to be closer to the logic that existed prior to the patch that addressed support for multiple, distinct root paths. The fix that was merged was overly complex, and not necessarily so. This update simplifies that patch to the necessary bits.
Configuration menu - View commit details
-
Copy full SHA for 7c5a4ee - Browse repository at this point
Copy the full SHA 7c5a4eeView commit details
Commits on Jun 2, 2022
-
fix: allow setting PreserveUnknownFields at both type and field level
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1df4fab - Browse repository at this point
Copy the full SHA 1df4fabView commit details
Commits on Jun 3, 2022
-
Merge pull request kubernetes-sigs#687 from akutz/feature/simplify-fi…
…x-for-680 🏃 Simplify the LoadRootsWithConfig logic
Configuration menu - View commit details
-
Copy full SHA for 11b6dd2 - Browse repository at this point
Copy the full SHA 11b6dd2View commit details
Commits on Jun 13, 2022
-
✨ crd/gen: sort FindKubeKinds (kubernetes-sigs#679)
* 🐛 crd/gen: Sort findGroupKinds * remove binary
Configuration menu - View commit details
-
Copy full SHA for 59485af - Browse repository at this point
Copy the full SHA 59485afView commit details -
Merge pull request kubernetes-sigs#685 from mistydemeo/yaml_v3_update
✨ Upgrade the yaml from v3.0.0-20210107192922-496545a6307b to 3.0.0
Configuration menu - View commit details
-
Copy full SHA for 7ba1644 - Browse repository at this point
Copy the full SHA 7ba1644View commit details -
Merge pull request kubernetes-sigs#689 from eddycharly/master
🐛 Allow setting PreserveUnknownFields at both type and field level
Configuration menu - View commit details
-
Copy full SHA for d97fa93 - Browse repository at this point
Copy the full SHA d97fa93View commit details
Commits on Jun 14, 2022
-
🐛 Add XPreserveUnknownFields to runtime.RawExtension (kubernetes-sigs…
…#683) * Add XPreserveUnknownFields to runtime.RawExtension Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> * fix: tests Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> * fix: generate crd manifests Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 529c857 - Browse repository at this point
Copy the full SHA 529c857View commit details
Commits on Jun 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3ea6625 - Browse repository at this point
Copy the full SHA 3ea6625View commit details
Commits on Jun 27, 2022
-
Merge pull request kubernetes-sigs#692 from chrischdi/pr-topology-mar…
…kers-to-type 🐛 Make topology markers also valid for type definitions
Configuration menu - View commit details
-
Copy full SHA for 6bfa604 - Browse repository at this point
Copy the full SHA 6bfa604View commit details
Commits on Jun 29, 2022
-
Fix crd flattening for XMapType to not duplicate entries
Bug was introduced in kubernetes-sigs#693.
Configuration menu - View commit details
-
Copy full SHA for 1bb8449 - Browse repository at this point
Copy the full SHA 1bb8449View commit details -
Merge pull request kubernetes-sigs#697 from chrischdi/pr-fix-XMapType…
…Flatten 🐛 Fix crd flattening for structType marker to not create duplicate entries for XMapType
Configuration menu - View commit details
-
Copy full SHA for 1878064 - Browse repository at this point
Copy the full SHA 1878064View commit details
Commits on Jul 4, 2022
-
Merge pull request kubernetes-sigs#689 from eddycharly/master
🐛 Allow setting PreserveUnknownFields at both type and field level Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 65ed27c - Browse repository at this point
Copy the full SHA 65ed27cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 082b38f - Browse repository at this point
Copy the full SHA 082b38fView commit details -
Merge branch 'release-0.9' of https://github.com/kubernetes-sigs/cont…
…roller-tools into release-0.9 Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f272ee - Browse repository at this point
Copy the full SHA 0f272eeView commit details