Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.9] 🐛 Allow setting PreserveUnknownFields at both type and field level #700

Closed
wants to merge 18 commits into from

Commits on May 25, 2022

  1. ci: fix golangci-lint installation

    `install.goreleaser.com` is now deprecated and stopped working so the tests
    in new PRs are failing.
    ahmetb committed May 25, 2022
    Configuration menu
    Copy the full SHA
    edb8efc View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#682 from ahmetb/fix-test

    🐛 ci: fix golangci-lint installation
    k8s-ci-robot committed May 25, 2022
    Configuration menu
    Copy the full SHA
    f89071a View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. gopkg.in/yaml.v3 v3.0.0

    mistydemeo committed May 26, 2022
    Configuration menu
    Copy the full SHA
    4fefd28 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. 🐛 crdgen: compare metav1 pkg by ID (kubernetes-sigs#681)

    * crdgen: compare metav1 pkg by ID & fsp loader
    
    This patch updates the way the CRD generator compares an imported
    metav1 package. Previously the comparison occurred using a Golang
    equality operator, !=, against two, in-memory data structures.
    However, this fails when multiple root paths are loaded. Their
    metav1 packages are identical, just not identical objects in
    memory. This patch updates the comparison to compare the package
    IDs, not the instance of the object.
    
    This patch also introduces a filesystem-path specific loader for
    each unique filesystem path provided as a root. This ensures the
    AST is loaded correctly and the kubebuilder markers are parsed as
    intended.
    
    * Reproduce the issue
    
    This patch adds tests to reproduce the issue of the markers
    not being discovered when multiple paths are used.
    
    The issue is not markers missing from a type, but markers missing
    from a *referenced* type. For example, the new Job type imports
    the unserved.CronJobSpec as the field Job.Spec.CronJob. The
    markers are not generated for Job.Spec.CronJob as it is referenced
    from another package.
    akutz committed May 31, 2022
    Configuration menu
    Copy the full SHA
    ea90e81 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Simplify the LoadRootsWithConfig logic

    This patch simplifies the LoadRootsWithConfig logic to be closer
    to the logic that existed prior to the patch that addressed support
    for multiple, distinct root paths. The fix that was merged was
    overly complex, and not necessarily so. This update simplifies
    that patch to the necessary bits.
    akutz committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    7c5a4ee View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. fix: allow setting PreserveUnknownFields at both type and field level

    Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
    eddycharly committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    1df4fab View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Merge pull request kubernetes-sigs#687 from akutz/feature/simplify-fi…

    …x-for-680
    
    🏃 Simplify the LoadRootsWithConfig logic
    k8s-ci-robot committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    11b6dd2 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. ✨ crd/gen: sort FindKubeKinds (kubernetes-sigs#679)

    * 🐛 crd/gen: Sort findGroupKinds
    
    * remove binary
    gshirazi committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    59485af View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#685 from mistydemeo/yaml_v3_update

    ✨  Upgrade the yaml from v3.0.0-20210107192922-496545a6307b to 3.0.0
    k8s-ci-robot committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    7ba1644 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#689 from eddycharly/master

    🐛 Allow setting PreserveUnknownFields at both type and field level
    k8s-ci-robot committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    d97fa93 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. 🐛 Add XPreserveUnknownFields to runtime.RawExtension (kubernetes-sigs…

    …#683)
    
    * Add XPreserveUnknownFields to runtime.RawExtension
    
    Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
    
    * fix: tests
    
    Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
    
    * fix: generate crd manifests
    
    Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
    eddycharly committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    529c857 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Configuration menu
    Copy the full SHA
    3ea6625 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Merge pull request kubernetes-sigs#692 from chrischdi/pr-topology-mar…

    …kers-to-type
    
    🐛 Make topology markers also valid for type definitions
    k8s-ci-robot committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    6bfa604 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Configuration menu
    Copy the full SHA
    1bb8449 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#697 from chrischdi/pr-fix-XMapType…

    …Flatten
    
    🐛 Fix crd flattening for structType marker to not create duplicate entries for XMapType
    k8s-ci-robot committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    1878064 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Merge pull request kubernetes-sigs#689 from eddycharly/master

    🐛 Allow setting PreserveUnknownFields at both type and field level
    
    Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
    k8s-ci-robot authored and eddycharly committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    65ed27c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    082b38f View commit details
    Browse the repository at this point in the history
  3. Merge branch 'release-0.9' of https://github.com/kubernetes-sigs/cont…

    …roller-tools into release-0.9
    
    Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
    eddycharly committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    0f272ee View commit details
    Browse the repository at this point in the history