🐛 Add XPreserveUnknownFields to runtime.RawExtension (#683)

* Add XPreserveUnknownFields to runtime.RawExtension Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> * fix: tests Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> * fix: generate crd manifests Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
kubernetes-sigs · Jun 14, 2022 · 529c857 · 529c857
1 parent d97fa93
commit 529c857
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pkg/crd/known_types.go b/pkg/crd/known_types.go
@@ -74,7 +74,8 @@ var KnownPackages = map[string]PackageOverride{
 	"k8s.io/apimachinery/pkg/runtime": func(p *Parser, pkg *loader.Package) {
 		p.Schemata[TypeIdent{Name: "RawExtension", Package: pkg}] = apiext.JSONSchemaProps{
 			// TODO(directxman12): regexp validation for this (or get kube to support it as a format value)
-			Type: "object",
+			Type:                   "object",
+			XPreserveUnknownFields: boolPtr(true),
 		}
 		p.AddPackage(pkg) // get the rest of the types
 	},

diff --git a/pkg/crd/testdata/testdata.kubebuilder.io_cronjobs.yaml b/pkg/crd/testdata/testdata.kubebuilder.io_cronjobs.yaml
@@ -134,6 +134,7 @@ spec:
               embeddedResource:
                 type: object
                 x-kubernetes-embedded-resource: true
+                x-kubernetes-preserve-unknown-fields: true
               failedJobsHistoryLimit:
                 description: The number of failed finished jobs to retain. This is
                   a pointer to distinguish between explicit zero and not specified.