-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enable using setup-envtest without a separate CLI #2810
Draft
tomasaschan
wants to merge
21
commits into
kubernetes-sigs:main
Choose a base branch
from
tomasaschan:tomasaschan/setup-envtest-in-band
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
✨ Enable using setup-envtest without a separate CLI #2810
tomasaschan
wants to merge
21
commits into
kubernetes-sigs:main
from
tomasaschan:tomasaschan/setup-envtest-in-band
Commits on Apr 21, 2024
-
Duplicate code from setup-envtest that can be easily reused
Since the error handling in the setup-envtest executable main path is built on panics, recovers and os.Exit, it isn't ideal for re-using in a version that downloads binaries within the test run. However, much of the heavy lifting is performed by the remote, store and versions packages, which _do_ properly return errors, and can readily be reused in a new implementation. This commit just duplicates the code from under tools/setup-envtest to pkg/envtest, where we can build a new entry point that is easier to use from within tests.
Configuration menu - View commit details
-
Copy full SHA for 540e4ff - Browse repository at this point
Copy the full SHA 540e4ffView commit details
Commits on Apr 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 11ed5ff - Browse repository at this point
Copy the full SHA 11ed5ffView commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2b6dcd6 - Browse repository at this point
Copy the full SHA 2b6dcd6View commit details
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 994bdf9 - Browse repository at this point
Copy the full SHA 994bdf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5895e96 - Browse repository at this point
Copy the full SHA 5895e96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cb9e36 - Browse repository at this point
Copy the full SHA 5cb9e36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36c1749 - Browse repository at this point
Copy the full SHA 36c1749View commit details -
This also removes the last references to the old env package!
Configuration menu - View commit details
-
Copy full SHA for 0b7a1f5 - Browse repository at this point
Copy the full SHA 0b7a1f5View commit details -
Harmonize WithEnvOptions to plural
Also ensure binDir option is used in all workflows
Configuration menu - View commit details
-
Copy full SHA for 4cbd6c4 - Browse repository at this point
Copy the full SHA 4cbd6c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3006cda - Browse repository at this point
Copy the full SHA 3006cdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for caa6a3f - Browse repository at this point
Copy the full SHA caa6a3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a7141 - Browse repository at this point
Copy the full SHA 63a7141View commit details -
Configuration menu - View commit details
-
Copy full SHA for e10c2f5 - Browse repository at this point
Copy the full SHA e10c2f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3a4f85 - Browse repository at this point
Copy the full SHA b3a4f85View commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a99e5c3 - Browse repository at this point
Copy the full SHA a99e5c3View commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dc226b6 - Browse repository at this point
Copy the full SHA dc226b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for eafaf70 - Browse repository at this point
Copy the full SHA eafaf70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 843e86e - Browse repository at this point
Copy the full SHA 843e86eView commit details
Commits on May 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4f6aa89 - Browse repository at this point
Copy the full SHA 4f6aa89View commit details
Commits on May 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8cebb21 - Browse repository at this point
Copy the full SHA 8cebb21View commit details
Commits on Jun 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3d4a463 - Browse repository at this point
Copy the full SHA 3d4a463View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.