New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 verify.sh: verify generate & modules (in CI) #2186
馃尡 verify.sh: verify generate & modules (in CI) #2186
Conversation
|
||
# Only run module verification in CI, otherwise updating | ||
header_text "running modules" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flipped the order here so we first run go mod tidy before running the linter.
Depending on the state of the go.mod files the linter could fail because they are out-of-date.
/assign @vincepri /cc @alvaroaleman |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow-up to #2096 to ensure we always verify that go modules and generated files are up-to-date.
(verify.sh is run by our presubmit test job)