Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 OWNERS_ALIASES: move fillzpp to maintainers #1932

Closed

Conversation

FillZpp
Copy link
Contributor

@FillZpp FillZpp commented Jun 15, 2022

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Moves me (@FillZpp ) to maintainers to improve coverage for maintainer-requiring tasks, e.g. making releases (following RELEASE.md, thanks to @camilamacedo86 ).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2022
@FillZpp
Copy link
Contributor Author

FillZpp commented Jun 15, 2022

/cc @alvaroaleman @joelanford @vincepri

@FillZpp
Copy link
Contributor Author

FillZpp commented Jun 20, 2022

Hey guys @alvaroaleman @joelanford @vincepri @camilamacedo86 , what do you think?

Please let me know if there鈥檚 anything else I should do. Your suggestions are very appreciated :)

@camilamacedo86
Copy link
Member

Hi @FillZpp,

Hey guys @alvaroaleman @joelanford @vincepri @camilamacedo86 , what do you think?
Please let me know if there鈥檚 anything else I should do. Your suggestions are very appreciated :)

It really needs to be with them. I am more on the Kuebuilder side of the world.
In Kubebuilder we do have not the maintainers field (we only have https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/CONTRIBUTING-ROLES.md + admin), not sure how it has been defined/categorized here.

@FillZpp
Copy link
Contributor Author

FillZpp commented Jun 23, 2022

It really needs to be with them. I am more on the Kuebuilder side of the world.
In Kubebuilder we do have not the maintainers field (we only have https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/CONTRIBUTING-ROLES.md + admin), not sure how it has been defined/categorized here.

Thanks, I understand. Although it seems Kubebuilder has both admin and maintainer roles.But controller-runtime (and controller-tools) are mostly using maintainer role, the admin list seems to be obsolete.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 21, 2022
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 28, 2022
@FillZpp
Copy link
Contributor Author

FillZpp commented Oct 29, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 29, 2022
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2022
@camilamacedo86
Copy link
Member

/lgtm

Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I am in favor of this. @joelanford @vincepri any objections?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, FillZpp, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@vincepri
Copy link
Member

vincepri commented Dec 1, 2022

Hey folks, just looking through this issue, I'm generally in favor of promoting new members to have a larger footprint in the community. That said, going by the community guidelines https://github.com/kubernetes/community/blob/master/community-membership.md I don't think we're quite there yet by looking at the amount of contributions done so far, or reviews.

If this is mostly about releases, I'd suggest that we work on automating the release process as much as possible through github actions, and have it self contained, like we did in the Cluster API project.

@FillZpp
Copy link
Contributor Author

FillZpp commented Dec 2, 2022

Hey folks, just looking through this issue, I'm generally in favor of promoting new members to have a larger footprint in the community. That said, going by the community guidelines https://github.com/kubernetes/community/blob/master/community-membership.md I don't think we're quite there yet by looking at the amount of contributions done so far, or reviews.

Oh, thanks for your feedback. I can add some information:

  • I have posted 10+ PR and been merged, also I'm still working on some features like stoppable controllers/watches. This is partly due to the fact that there just aren't many of big changes in the project nowadays, but I'm still willing to make it better continuously.
  • I have been part of 50+ issues, discussing, answering questions.
  • I have involved and assigned in 80+ PPs, in most of them I helped review and gave my suggestions.

@vincepri Not sure which requirements you mentioned I'm still not reached from the membership doc. Could you please make it clear so that I could make my efforts towards it?

Thanks!

@vincepri
Copy link
Member

vincepri commented Dec 9, 2022

@FillZpp Thank you for the summary! I've missed a lot of these when I looked around.

LGTM, can we move though from maintainer to approver list?

@vincepri
Copy link
Member

vincepri commented Dec 9, 2022

Superseded by #2088

/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closed this PR.

In response to this:

Superseded by #2088

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants