Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.12] ⚠ Add GetOptions as optional argument of client.Reader and all its implementation #1925

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #1917

/assign FillZpp

…ementation

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
To complete the pull request process, please assign mengqiy after the PR has been reviewed.
You can assign the PR to them by writing /assign @mengqiy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2022
@FillZpp
Copy link
Contributor

FillZpp commented Jun 6, 2022

/lgtm
/cc @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
@alvaroaleman
Copy link
Member

@FillZpp sorry, but this is a breaking change, we don't do breaking changes within a minor release

@FillZpp
Copy link
Contributor

FillZpp commented Jun 6, 2022

@FillZpp sorry, but this is a breaking change, we don't do breaking changes within a minor release

Oh, understand. So it has to wait for 0.13 release.

/close

@k8s-ci-robot
Copy link
Contributor

@FillZpp: Closed this PR.

In response to this:

@FillZpp sorry, but this is a breaking change, we don't do breaking changes within a minor release

Oh, understand. So it has to wait for 0.13 release.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants