✨ Enable metrics of clientgo leader election #1901

zqzten · 2022-05-14T05:48:51Z

This PR enables metrics of clientgo leader election ( "k8s.io/client-go/tools/leaderelection" )

k8s-ci-robot · 2022-05-14T05:48:58Z

Welcome @zqzten!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-05-14T05:48:59Z

Hi @zqzten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

FillZpp · 2022-05-14T08:45:49Z

/label tide/merge-method-squash
/ok-to-test

pkg/metrics/leaderelection.go

pkg/metrics/client_go_adapter.go

pkg/manager/internal.go

camilamacedo86

@zqzten,

Thank you for the contribution 🥇
I updated the first comment to try to clarify the questions made as well. I hope that you like it. However, please feel free to change.

Could you rebase the commits so we can move forward?
Otherwise, it shows for me

/lgtm

@varshaprasad96 @alvaroaleman wdyt?

zqzten · 2022-05-25T10:42:05Z

@camilamacedo86 Thanks for the clarification, it looks better👍. Code is rebased.

zqzten · 2022-05-26T13:08:19Z

/assign @joelanford

camilamacedo86

/lgtm

zqzten · 2022-06-06T06:55:43Z

Friendly ping @joelanford for approval or further comments

alvaroaleman · 2022-06-27T20:29:38Z

@zqzten please make seperate PRs for removing the metrics and adding new ones so both the changes appear in the changelog

zqzten · 2022-06-28T07:56:13Z

@alvaroaleman Okay, I've seperated the removal to #1946, PTAL.

zqzten · 2022-06-30T03:16:02Z

@alvaroaleman Could you also help approve this PR? It seems that there's no response from other assignees for some time. Thanks!

k8s-triage-robot · 2022-09-28T03:43:36Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

zqzten · 2022-09-30T11:59:52Z

/remove-lifecycle stale

@alvaroaleman @joelanford Need lgtm approve here, thanks!

camilamacedo86 · 2022-11-24T08:17:27Z

/lgtm

@alvaroaleman @joelanford @vincepri

Can we move with this one?

pkg/metrics/leaderelection.go

alvaroaleman · 2022-11-25T17:15:33Z

pkg/manager/internal.go

@@ -633,6 +636,7 @@ func (cm *controllerManager) startLeaderElection(ctx context.Context) (err error
 			},
 		},
 		ReleaseOnCancel: cm.leaderElectionReleaseOnCancel,
+		Name:            cm.leaderElectionID,


TILd Label values may contain any unicode character, ref https://prometheus.io/docs/concepts/data_model/ so we don't have to sanitize this

alvaroaleman

Thanks!

k8s-ci-robot · 2022-12-01T04:57:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, camilamacedo86, zqzten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 14, 2022

k8s-ci-robot requested review from alenkacz and shawn-hurley May 14, 2022 05:49

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 14, 2022

camilamacedo86 reviewed May 17, 2022

View reviewed changes

pkg/metrics/leaderelection.go Show resolved Hide resolved

camilamacedo86 reviewed May 17, 2022

View reviewed changes

pkg/metrics/client_go_adapter.go Outdated Show resolved Hide resolved

zqzten requested a review from camilamacedo86 May 21, 2022 03:20

camilamacedo86 reviewed May 23, 2022

View reviewed changes

pkg/manager/internal.go Show resolved Hide resolved

camilamacedo86 approved these changes May 25, 2022

View reviewed changes

k8s-ci-robot assigned camilamacedo86 May 25, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022

zqzten force-pushed the metrics branch from 2b72a25 to 67e0cbb Compare May 25, 2022 10:39

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022

k8s-ci-robot assigned joelanford May 26, 2022

camilamacedo86 reviewed May 26, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2022

zqzten force-pushed the metrics branch from 67e0cbb to 42415fa Compare June 28, 2022 07:37

k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2022

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2022

zqzten mentioned this pull request Jun 28, 2022

🐛 Remove no-op clientgo reflector metrics #1946

Merged

zqzten force-pushed the metrics branch from 42415fa to ed5546b Compare June 28, 2022 07:49

zqzten mentioned this pull request Jul 2, 2022

REQUEST: New membership for zqzten kubernetes/org#3537

Closed

9 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2022

alvaroaleman reviewed Nov 25, 2022

View reviewed changes

pkg/metrics/leaderelection.go Outdated Show resolved Hide resolved

alvaroaleman reviewed Nov 25, 2022

View reviewed changes

zqzten added 2 commits November 30, 2022 17:20

tweak comment of the workqueue metrics file

a993c00

enable metrics of clientgo leader election

9751519

zqzten force-pushed the metrics branch from ed5546b to 9751519 Compare November 30, 2022 09:26

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2022

zqzten requested review from alvaroaleman and removed request for alenkacz and shawn-hurley November 30, 2022 09:32

alvaroaleman approved these changes Dec 1, 2022

View reviewed changes

k8s-ci-robot assigned alvaroaleman Dec 1, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022

k8s-ci-robot merged commit d991225 into kubernetes-sigs:master Dec 1, 2022

zqzten deleted the metrics branch December 1, 2022 06:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Enable metrics of clientgo leader election #1901

✨ Enable metrics of clientgo leader election #1901

zqzten commented May 14, 2022 •

edited

k8s-ci-robot commented May 14, 2022

k8s-ci-robot commented May 14, 2022

FillZpp commented May 14, 2022

camilamacedo86 left a comment •

edited

zqzten commented May 25, 2022

zqzten commented May 26, 2022

camilamacedo86 left a comment

zqzten commented Jun 6, 2022

alvaroaleman commented Jun 27, 2022

zqzten commented Jun 28, 2022

zqzten commented Jun 30, 2022 •

edited

k8s-triage-robot commented Sep 28, 2022

zqzten commented Sep 30, 2022

camilamacedo86 commented Nov 24, 2022

alvaroaleman Nov 25, 2022

alvaroaleman left a comment

k8s-ci-robot commented Dec 1, 2022

✨ Enable metrics of clientgo leader election #1901

✨ Enable metrics of clientgo leader election #1901

Conversation

zqzten commented May 14, 2022 • edited

k8s-ci-robot commented May 14, 2022

k8s-ci-robot commented May 14, 2022

FillZpp commented May 14, 2022

camilamacedo86 left a comment • edited

Choose a reason for hiding this comment

zqzten commented May 25, 2022

zqzten commented May 26, 2022

camilamacedo86 left a comment

Choose a reason for hiding this comment

zqzten commented Jun 6, 2022

alvaroaleman commented Jun 27, 2022

zqzten commented Jun 28, 2022

zqzten commented Jun 30, 2022 • edited

k8s-triage-robot commented Sep 28, 2022

zqzten commented Sep 30, 2022

camilamacedo86 commented Nov 24, 2022

alvaroaleman Nov 25, 2022

Choose a reason for hiding this comment

alvaroaleman left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 1, 2022

zqzten commented May 14, 2022 •

edited

camilamacedo86 left a comment •

edited

zqzten commented Jun 30, 2022 •

edited