Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Envtest should modify CRDs appropriately when using webhooks #1525

Merged
merged 1 commit into from May 14, 2021
Merged

⚠️ Envtest should modify CRDs appropriately when using webhooks #1525

merged 1 commit into from May 14, 2021

Commits on May 14, 2021

  1. Envtest should modify CRDs appropriately when using webhooks 

    Before this change, the webhook code was patching mutation or admission
webhooks to point to the temporary URL and CA bundle generated when the
webhook server would start.

Conversion webhooks are handled at the CRD level in Kubernetes, and we
need to make sure to patch those client configurations as well.

This patch also unexports a lot of methods that should have been private
from the very beginning, so it's marked as a breaking change.

Signed-off-by: Vince Prignano <vincepri@vmware.com>
    @vincepri
    vincepri committed May 14, 2021
    Configuration menu
    Copy the full SHA
    2bfe5cf View commit details
    Browse the repository at this point in the history