Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Finalizer helper library #1481

Merged
merged 7 commits into from Jun 8, 2021
Merged

✨Finalizer helper library #1481

merged 7 commits into from Jun 8, 2021

Commits on Jun 7, 2021

  1. Initial commit for finalizer helper library 

    Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
    @rashmigottipati
    rashmigottipati committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    0a3b455 View commit details
    Browse the repository at this point in the history

  2. Add unit tests 

    Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
    @rashmigottipati
    rashmigottipati committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    c6fecbb View commit details
    Browse the repository at this point in the history

  3. Address review comments 

    Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
    @rashmigottipati
    rashmigottipati committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    9f61089 View commit details
    Browse the repository at this point in the history

  4. Add needsUpdate and err fields on mockFinalizer struct for customizat… 

    …ions

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
    @rashmigottipati
    rashmigottipati committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    b269322 View commit details
    Browse the repository at this point in the history

  5. Address review feedback kubernetes-sigs#2 

    Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
    @rashmigottipati
    rashmigottipati committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    ac093b0 View commit details
    Browse the repository at this point in the history

  6. Split needsUpdate into two separate variables and update unit tests 

    Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
    @rashmigottipati
    rashmigottipati committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    60ab6fd View commit details
    Browse the repository at this point in the history

  7. Address review feedback kubernetes-sigs#3 

    Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
    @rashmigottipati
    rashmigottipati committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    5eb033d View commit details
    Browse the repository at this point in the history