New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Pass webhook decoder through sub-dependencies when scheme is injected after injector #1437
🐛 Pass webhook decoder through sub-dependencies when scheme is injected after injector #1437
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @impl! |
Hi @impl. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: impl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @DirectXMan12 and @pwittrock, I'd love to get your feedback on this PR if you're able to take a look! Happy to make any adjustments needed. Thanks so much! |
Fixes in #1502 |
It is currently impossible to chain validating/defaulting webhooks using the multi-handlers because the decoder never gets properly passed down through the dependency chain if the scheme happens to be injected after the injection func. This change fixes that logic and adds helper methods to create standalone Handlers for Defaulters and Validators.
Without this change, we get a panic in the webhook when it receives a request. Here's an example of the kind of chaining we're trying to do: https://github.com/puppetlabs/pvpool/blob/12321f9da263ade52595493e1af60abb61c86050/pkg/webhook/checkout.go#L153-L163
I also have a cherry-pick for release-0.8 ready to go: release-0.8...puppetlabs:multi-webhook-sub-dependencies-release-0.8