Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix a race in the delegating logger #1339

Merged
merged 1 commit into from Jan 15, 2021

Commits on Jan 15, 2021

  1. 🐛 Fix a race in the delegating logger

    For as long as the delegating loggers Fullfill wasn't called, it holds a
    loggerPromise and that loggerPromise holds the same delegating logger.
    
    Calls to With{Name,Field} and FullFill of such a loggerPromise and
    delegatingLogger pair have to be serialized, because the former accesses
    the actual logger and promise, while the latter sets and unsets them.
    
    Furthermore, a call to With{Name,Field} of such a pair returns a new
    pair that is attached to the parent pair by making the original promise
    keep a reference to the new promise. Because of that, the aforementioned
    serialization has to happen recursively for each pair.
    alvaroaleman committed Jan 15, 2021
    Copy the full SHA
    2aaa357 View commit details
    Browse the repository at this point in the history