Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Move cluster-specifics from Manager into new pkg/cluster #1307

Merged
merged 1 commit into from Jan 6, 2021

Commits on Dec 23, 2020

  1. ✨ Move cluster-specifics from Manager into new pkg/cluster

    This change is the first step towards implementing the corresponding
    [proposal][1]. It essentially consists of moving a bunch if code from
    pkg/manager into pkg/cluster, slightly adjusting some tests in
    pkg/manager and copying applicable tests from there into pkg/cluster.
    
    It is not yet the full implementation, because the `Manager` will only
    correctly start it's own cache and not other caches before starting the
    remaining `Runnables`. This behavior matches current behavior when
    building something that uses multiple caches and will be fixed in a
    follow-up.
    
    [1]: https://github.com/kubernetes-sigs/controller-runtime/blob/master/designs/move-cluster-specific-code-out-of-manager.md
    alvaroaleman committed Dec 23, 2020
    Copy the full SHA
    066bfea View commit details
    Browse the repository at this point in the history