Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠ Fakeclient: Set ResourceVersion when adding objects to the tracker #1306

Merged
merged 1 commit into from Jan 6, 2021

Commits on Dec 23, 2020

  1. ⚠ Fakeclient: Set ResourceVersion when adding objects to the tracker

    Currently an object that is added to the tracker will not have a
    ResourceVersion set. This can lead to tests that should fail with an
    IsConflict error succeeding when:
    
    * The object is added to the tracker
    * The object allows UnconditionalUpdate, i.E. Update with an empty
      ResourceVersion that will never conflict
    * The code under test retrieves such an object and then does an Update
      for it
    
    As this change results in different ResourceVersions for tests it is
    breaking.
    alvaroaleman committed Dec 23, 2020
    Copy the full SHA
    51fb3f8 View commit details
    Browse the repository at this point in the history